Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0] Fix and Make aggregation planner handle aggregation functions better and handle Distinct in operator #13277

Merged
merged 2 commits into from
Jun 12, 2023
Merged

[17.0] Fix and Make aggregation planner handle aggregation functions better and handle Distinct in operator #13277

merged 2 commits into from
Jun 12, 2023

Commits on Jun 8, 2023

  1. Handle DISTINCT with the new operators (vitessio#13201) 

    * handle distinct with the new operators

Signed-off-by: Andres Taylor <[email protected]>

* feat: do not fail limit when offsets are present

Signed-off-by: Manan Gupta <[email protected]>

* test: add more DISTINCT end to end tests

Signed-off-by: Andres Taylor <[email protected]>

* remove limitation around aggregation and distinct

Signed-off-by: Andres Taylor <[email protected]>

---------

Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Co-authored-by: Manan Gupta <[email protected]>
    @systay @GuptaManan100 @harshit-gangal
    2 people authored and harshit-gangal committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    4a71f3d View commit details
    Browse the repository at this point in the history

  2. Fix and Make aggregation planner handle aggregation functions better (v… 

    …itessio#13228)

* handle unpushed aggregation better

Signed-off-by: Andres Taylor <[email protected]>

* distinct on aggregator and changed distinct engine primitive to take offset than truncate bool

Signed-off-by: Harshit Gangal <[email protected]>

* handle SUM with the new operator horizon planning

Signed-off-by: Andres Taylor <[email protected]>

* empty t10 after running tests

Signed-off-by: Andres Taylor <[email protected]>

* add collations and weight_string for aggregations where engine primitive is supported

Signed-off-by: Harshit Gangal <[email protected]>

* compare columns using semantic equality

Signed-off-by: Andres Taylor <[email protected]>

* handle grouping expressions that are returned in multiple columns

Signed-off-by: Andres Taylor <[email protected]>

* add end2end test to show that query works

Signed-off-by: Andres Taylor <[email protected]>

* on aggregate count and sum splittling create new aggr and update the column offset based on where it is pushed

Signed-off-by: Harshit Gangal <[email protected]>

* add waitForAuthoritative for last insert id test

Signed-off-by: Harshit Gangal <[email protected]>

* fix: push nil for min max cases for other side

Signed-off-by: Harshit Gangal <[email protected]>

* saves vtgate startup time as most of the test only have primary

Signed-off-by: Harshit Gangal <[email protected]>

* allow min/max without weight_string, projection to be created always on aggregation pushing with join, compact done later

Signed-off-by: Harshit Gangal <[email protected]>

---------

Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
Co-authored-by: Andres Taylor <[email protected]>
    @harshit-gangal @systay
    harshit-gangal and systay committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    561205f View commit details
    Browse the repository at this point in the history