-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0] Fix and Make aggregation planner handle aggregation functions better and handle Distinct in operator #13277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* handle distinct with the new operators Signed-off-by: Andres Taylor <[email protected]> * feat: do not fail limit when offsets are present Signed-off-by: Manan Gupta <[email protected]> * test: add more DISTINCT end to end tests Signed-off-by: Andres Taylor <[email protected]> * remove limitation around aggregation and distinct Signed-off-by: Andres Taylor <[email protected]> --------- Signed-off-by: Andres Taylor <[email protected]> Signed-off-by: Manan Gupta <[email protected]> Co-authored-by: Manan Gupta <[email protected]>
…itessio#13228) * handle unpushed aggregation better Signed-off-by: Andres Taylor <[email protected]> * distinct on aggregator and changed distinct engine primitive to take offset than truncate bool Signed-off-by: Harshit Gangal <[email protected]> * handle SUM with the new operator horizon planning Signed-off-by: Andres Taylor <[email protected]> * empty t10 after running tests Signed-off-by: Andres Taylor <[email protected]> * add collations and weight_string for aggregations where engine primitive is supported Signed-off-by: Harshit Gangal <[email protected]> * compare columns using semantic equality Signed-off-by: Andres Taylor <[email protected]> * handle grouping expressions that are returned in multiple columns Signed-off-by: Andres Taylor <[email protected]> * add end2end test to show that query works Signed-off-by: Andres Taylor <[email protected]> * on aggregate count and sum splittling create new aggr and update the column offset based on where it is pushed Signed-off-by: Harshit Gangal <[email protected]> * add waitForAuthoritative for last insert id test Signed-off-by: Harshit Gangal <[email protected]> * fix: push nil for min max cases for other side Signed-off-by: Harshit Gangal <[email protected]> * saves vtgate startup time as most of the test only have primary Signed-off-by: Harshit Gangal <[email protected]> * allow min/max without weight_string, projection to be created always on aggregation pushing with join, compact done later Signed-off-by: Harshit Gangal <[email protected]> --------- Signed-off-by: Andres Taylor <[email protected]> Signed-off-by: Harshit Gangal <[email protected]> Co-authored-by: Andres Taylor <[email protected]>
harshit-gangal
added
Type: Bug
Component: Query Serving
Backport
This is a backport
labels
Jun 8, 2023
harshit-gangal
requested review from
deepthi,
mattlord,
frouioui,
rohit-nayak-ps,
GuptaManan100,
systay,
shlomi-noach,
arthurschreiber,
ajm188,
derekperkins and
dkhenry
as code owners
June 8, 2023 20:01
vitess-bot
bot
added
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Jun 8, 2023
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
harshit-gangal
removed request for
arthurschreiber,
deepthi,
dkhenry,
mattlord and
shlomi-noach
June 8, 2023 20:03
harshit-gangal
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
labels
Jun 8, 2023
systay
approved these changes
Jun 12, 2023
frouioui
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a backport of #13201 and #13228
as both are related and fixes planner bugs.
Related Issue(s)
Checklist