Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vtbackup upgrade/downgrade test #12437

Merged
merged 4 commits into from
Feb 24, 2023
Merged

Fix vtbackup upgrade/downgrade test #12437

merged 4 commits into from
Feb 24, 2023

Conversation

rsajwani
Copy link
Contributor

@rsajwani rsajwani commented Feb 22, 2023 •
edited
Loading

Description

This PR fixes upgrade / downgrade tests for vtbackup. Prior to v16 we were using replication manager but now we use Vtorc for fixing the replication. During upgrade test we use VTTablet N+1 on branch 15 , this will result in backup test to fail as they don't have vtorc setup.

We have also removed TestReparentDoesntHangIfPrimaryFails given it is no longer valid after v16.

Related Issue(s)

This issue surfaced when we were backporting #12302 to release-15.0

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Feb 22, 2023
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Feb 22, 2023 •
edited
Loading

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@rsajwani rsajwani force-pushed the upgrade-downgrade-fix branch from 1d42245 to 7063db9 Compare February 22, 2023 22:23
@rsajwani rsajwani force-pushed the upgrade-downgrade-fix branch from 7063db9 to 48f2f35 Compare February 23, 2023 02:38
@rsajwani rsajwani changed the title Adding check for v16 in backup tests Fix vtbackup upgrade/downgrade test Feb 23, 2023
@rsajwani rsajwani force-pushed the upgrade-downgrade-fix branch from fb36c75 to e373b51 Compare February 23, 2023 23:12
@rsajwani rsajwani added Type: Bug Type: Testing and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Feb 24, 2023
@rsajwani rsajwani self-assigned this Feb 24, 2023
@rsajwani rsajwani added the Component: General Changes throughout the code base label Feb 24, 2023
@rsajwani rsajwani marked this pull request as ready for review February 24, 2023 06:35
GuptaManan100
GuptaManan100 requested changes Feb 24, 2023
View reviewed changes
.github/workflows/upgrade_downgrade_test_backups_e2e_next_release.yml
@@ -191,4 +191,4 @@ jobs:
mkdir -p /tmp/vtdataroot
set -x
source build.env
eatmydata -- go run test.go -skip-build -keep-data -docker=false -print-log -follow -tag upgrade_downgrade_backups
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at the code and keep-data defaults to true. So you can't just remove the flag. You actually need -keep-data=false. That is what I have done in #12462

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strictly it is not required since the tests are passing on this PR, but if we actually want to turn it off, then we need to do it this way.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initially it was false as default, we should move back to that. not for this PR

@GuptaManan100 GuptaManan100 merged commit 911f246 into vitessio:release-15.0 Feb 24, 2023
@GuptaManan100 GuptaManan100 deleted the upgrade-downgrade-fix branch February 24, 2023 17:17
@austenLacy austenLacy mentioned this pull request Apr 26, 2023
Merged
@austenLacy austenLacy mentioned this pull request Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@frouioui frouioui frouioui approved these changes

@harshit-gangal harshit-gangal harshit-gangal approved these changes

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

Assignees

@rsajwani rsajwani

Labels
Component: General Changes throughout the code base Type: Bug Type: Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rsajwani @harshit-gangal @frouioui @GuptaManan100