Fixes the SwitchTraffic bug that wasn't respecting --dry_run for readonly and replica tablets during a resharding event
#91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Austen Lacy <[email protected]>
austenLacy
requested review from
brendar,
hkdsun,
annzenkina,
WilliamLu99 and
toria-shopify
austenLacy
changed the title
SwitchTraffic bug that wasn't respect --dry_run for readonly and replica tablets during a resharding event
brendar
approved these changes
Apr 26, 2023
austenLacy
changed the title
SwitchTraffic bug that wasn't respect --dry_run for readonly and replica tablets during a resharding eventSwitchTraffic bug that wasn't respecting --dry_run for readonly and replica tablets during a resharding event
Yep, might as well. Will be curious to see if they'll accept it or reopen the original PR. Either way should be fine for us. |
hkdsun
approved these changes
Apr 27, 2023
Missing context? 🤔 |
|
@hkdsun the linked issue has a PR that was closed (not sure why) with the same fix - vitessio#6497 |
|
Upstream PR was merged - vitessio#12992 It had some e2e tests that have some conflicts with the |
|
I'm fine with merging as is |
austenLacy
deleted the
austenlacy/vitess-project-431/respect-dry-run-flag-on-switchtraffic
branch
shanth96
pushed a commit
that referenced
this pull request
Mar 21, 2024
Signed-off-by: Austen Lacy <[email protected]> Co-authored-by: Austen Lacy <[email protected]> (cherry picked from commit 46f1def)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: https://github.com/Shopify/vitess-project/issues/431
Fixes the
SwitchTrafficbug that wasn't respecting--dry_runfor readonly and replica tablets during a resharding event. More details specifically in this comment.