Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move CI workflow to use latest community version of mysql 8.0 #11493

Merged
merged 5 commits into from
Oct 17, 2022
Merged

Move CI workflow to use latest community version of mysql 8.0 #11493

merged 5 commits into from
Oct 17, 2022

Conversation

rsajwani
Copy link
Contributor

@rsajwani rsajwani commented Oct 13, 2022 •
edited by frouioui
Loading

Signed-off-by: Rameez Sajwani [email protected]

Description

This PR is build on top of #11153.
We are moving end to end and unit test to use latest version of MySql 8.0 instead of using percona. The reason for this is that Percona is still at 8.0.29, this doesn't allow our code base to test against the latest version of mysql.

Unit test are already on mysql community version but we are upgrading to higher apt-config version

Related Issue(s)

#11511

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@rsajwani
Move CI to mysql80
61f04a7 
Signed-off-by: Rameez Sajwani <[email protected]>
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Oct 13, 2022 •
edited by frouioui
Loading

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@rsajwani rsajwani changed the title Move CI to mysql80 [DONOT REVIEW] Move CI to mysql80 Oct 13, 2022
@rsajwani rsajwani self-assigned this Oct 13, 2022
@rsajwani
fix typo
525b234 
Signed-off-by: Rameez Sajwani <[email protected]>
@rsajwani rsajwani added Type: Enhancement Logical improvement (somewhere between a bug and feature) Forwardport to: main This will forward port the PR to the main branch labels Oct 13, 2022
@rsajwani rsajwani marked this pull request as ready for review October 14, 2022 01:01
@rsajwani rsajwani changed the title [DONOT REVIEW] Move CI to mysql80 Move CI to mysql80 Oct 14, 2022
frouioui
frouioui reviewed Oct 14, 2022
View reviewed changes
Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments. We should also update the PR's description to describe this change and ideally link to an issue if there is one.

@frouioui frouioui mentioned this pull request Oct 14, 2022
Closed
100 tasks
@frouioui
Copy link
Member

By the way, do we need to forwardport this to main considering the work that has been merged in this PR: #11153?

deepthi
deepthi reviewed Oct 14, 2022
View reviewed changes
test/templates/cluster_endtoend_test.tpl Outdated Show resolved Hide resolved
test/templates/unit_test.tpl Outdated Show resolved Hide resolved
@deepthi
Copy link
Member

deepthi commented Oct 14, 2022

By the way, do we need to forwardport this to main considering the work that has been merged in this PR: #11153?

This is why we need a better PR description.
#11153 is already present in release-15.0. On top of that this PR is changing the MySQL version we use from Percona to community version.
The reason for this is that Percona is still at 8.0.29, so the new backup code we wrote for changes in 8.0.30 is not being exercised.
Unit tests are already using community version. This PR changes endtoend tests to do the same (except xtrabackup tests).

@rsajwani rsajwani changed the title Move CI to mysql80 [DO NOT REVEIW] Move CI to mysql80 Oct 14, 2022
@rsajwani rsajwani changed the title [DO NOT REVEIW] Move CI to mysql80 [DO NOT REVEIW] Move CI workflow to use community version of mysql 8.0.3 Oct 14, 2022
@rsajwani
moving to apt-config 8.2
be82649 
Signed-off-by: Rameez Sajwani <[email protected]>
@deepthi deepthi changed the title [DO NOT REVEIW] Move CI workflow to use community version of mysql 8.0.3 [DO NOT REVEIW] Move CI workflow to use community version of mysql 8.0 Oct 14, 2022
@deepthi deepthi changed the title [DO NOT REVEIW] Move CI workflow to use community version of mysql 8.0 Move CI workflow to use latest community version of mysql 8.0 Oct 14, 2022
@rsajwani
Copy link
Contributor Author

rsajwani commented Oct 15, 2022 •
edited
Loading

FYI, Cluster (26)
was failing ..I tried to debug but doesn't seems it is because of my change. Running it manually then passed... So i am attributing it to flakiness...

frouioui
frouioui approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now

@deepthi deepthi merged commit 012bf09 into vitessio:release-15.0 Oct 17, 2022
@deepthi deepthi deleted the ci-mysql80 branch October 17, 2022 15:45
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Oct 17, 2022

I was unable to forwardport this Pull Request to the following branches: main.

@deepthi
Copy link
Member

deepthi commented Oct 17, 2022

@frouioui @GuptaManan100 can you review the upgrade/downgrade tests to see what versions we use there, and whether any changes are needed?

@frouioui
Copy link
Member

@deepthi, this issue should be addressed as soon as we merge #11509

@deepthi deepthi mentioned this pull request Oct 19, 2022
Closed
4 tasks
rsajwani added a commit to planetscale/vitess that referenced this pull request Nov 1, 2022
@rsajwani
Move CI workflow to use latest community version of mysql 8.0 (vitess…
9743eac 
…io#11493)

* Move CI to mysql80

Signed-off-by: Rameez Sajwani <[email protected]>

* fix typo

Signed-off-by: Rameez Sajwani <[email protected]>

* fixing typo

Signed-off-by: Rameez Sajwani <[email protected]>

* moving to apt-config 8.2

Signed-off-by: Rameez Sajwani <[email protected]>

Signed-off-by: Rameez Sajwani <[email protected]>
@rsajwani rsajwani mentioned this pull request Nov 2, 2022
Merged
3 tasks
GuptaManan100 pushed a commit that referenced this pull request Nov 3, 2022
@rsajwani
Move CI workflow to use latest community version of mysql 8.0 (#11493) (
531ba1b 
#11618)

* Move CI to mysql80

Signed-off-by: Rameez Sajwani <[email protected]>

* fix typo

Signed-off-by: Rameez Sajwani <[email protected]>

* fixing typo

Signed-off-by: Rameez Sajwani <[email protected]>

* moving to apt-config 8.2

Signed-off-by: Rameez Sajwani <[email protected]>

Signed-off-by: Rameez Sajwani <[email protected]>

Signed-off-by: Rameez Sajwani <[email protected]>
@austenLacy austenLacy mentioned this pull request Apr 26, 2023
Merged
@austenLacy austenLacy mentioned this pull request Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi left review comments

@frouioui frouioui frouioui approved these changes

Assignees

@rsajwani rsajwani

Labels
Component: Build/CI Forwardport to: main This will forward port the PR to the main branch Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rsajwani @frouioui @deepthi