Backport: For partial MoveTables, setup reverse shard routing rules on workflow creation #11447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… creation (vitessio#11415) * Testing.... Signed-off-by: Matt Lord <[email protected]> * Setup reverse routing rules at the start of the first partial movetables. Enhance e2e test to test for this as well as switch the remaining shard so that all shards are switched Signed-off-by: Rohit Nayak <[email protected]> * Update display representation of state for partially moved keyspaces Signed-off-by: Rohit Nayak <[email protected]> * Test improvements Signed-off-by: Matt Lord <[email protected]> * Cleanup shard routing rules on cancel/complete Signed-off-by: Matt Lord <[email protected]> * Cleanup intermediate changes Signed-off-by: Matt Lord <[email protected]> * Fix DryRun TrafficSwitcher and its tests Signed-off-by: Matt Lord <[email protected]> * Support concurrent partial movetables for N keyspaces And other minor changes after self review Signed-off-by: Matt Lord <[email protected]> * Avoid unnecessary save + rebuild steps Signed-off-by: Matt Lord <[email protected]> * Add secondary ordering for shard routing rules on to_keyspace Signed-off-by: Matt Lord <[email protected]> * Minor changes after self review Signed-off-by: Matt Lord <[email protected]> Signed-off-by: Matt Lord <[email protected]> Signed-off-by: Rohit Nayak <[email protected]> Co-authored-by: Rohit Nayak <[email protected]>
mattlord
added
Type: Enhancement
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For normal
MoveTablesoperations — where you're moving tables from one keyspace to another, i.e. the move is at the keyspace level — global routing rules are put in place when the workflow is created so that any attempted access of those tables on the target keyspace are routed to the source keyspace. (In this scenario shard targeting is how you would explicitly get around this routing.)For partial
MoveTablesoperations, you're moving the tables from one keyspace to another one shard at a time — so the move is per shard rather than per keyspace. In this scenario you want all traffic to go to one side or the other for a given shard, including shard targeted queries. This then offers the same kind of "global" (scoped to a shard) routing at the shard level that you would expect when doing keyspace levelMoveTables. This PR implements that functionality.Related Issue(s)
Checklist