Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Ubuntu 20.04 for endtoend tests #11113

Merged
merged 1 commit into from
Aug 30, 2022
Merged

Upgrade to Ubuntu 20.04 for endtoend tests #11113

merged 1 commit into from
Aug 30, 2022

Conversation

dbussink
Copy link
Contributor

This extracts the update to Ubuntu 20.04 (and thus MySQL 8 by default) just for the end to end tests and updates the associated tests.

Related Issue(s)

Extracted from #11026

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

@vitess-bot
Copy link
Contributor

vitess-bot bot commented Aug 29, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive. Additionally, flag names should use dashes (-) as word separators rather than underscores (_).
  • If a workflow is added or modified, each items in Jobs should be named in order to mark it as required. If the workflow should be required, the GitHub Admin should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

@dbussink
Upgrade to Ubuntu 20.04 for endtoend tests
e90c1a4 
This extracts the update to Ubuntu 20.04 (and thus MySQL 8 by default)
just for the end to end tests and updates the associated tests.

Signed-off-by: Dirkjan Bussink <[email protected]>
@dbussink dbussink force-pushed the dbussink/upgrade-end-to-end-tests branch from b5ac126 to e90c1a4 Compare August 29, 2022 18:03
@dbussink dbussink marked this pull request as ready for review August 29, 2022 19:24
@harshit-gangal harshit-gangal merged commit afa2eef into vitessio:main Aug 30, 2022
@harshit-gangal harshit-gangal deleted the dbussink/upgrade-end-to-end-tests branch August 30, 2022 10:21
notfelineit pushed a commit to planetscale/vitess that referenced this pull request Sep 21, 2022
@dbussink
Upgrade to Ubuntu 20.04 for endtoend tests (vitessio#11113) (vitessio…
7a44995 
…#1015)

This extracts the update to Ubuntu 20.04 (and thus MySQL 8 by default)
just for the end to end tests and updates the associated tests.

Signed-off-by: Dirkjan Bussink <[email protected]>

Signed-off-by: Dirkjan Bussink <[email protected]>

Signed-off-by: Dirkjan Bussink <[email protected]>
dbussink added a commit to planetscale/vitess that referenced this pull request Dec 1, 2022
@dbussink
Upgrade to Ubuntu 20.04 for endtoend tests (vitessio#11113)
d2fa0f7 
This extracts the update to Ubuntu 20.04 (and thus MySQL 8 by default)
just for the end to end tests and updates the associated tests.

Signed-off-by: Dirkjan Bussink <[email protected]>

Signed-off-by: Dirkjan Bussink <[email protected]>
@dbussink dbussink mentioned this pull request Dec 1, 2022
Merged
3 tasks
frouioui pushed a commit that referenced this pull request Dec 6, 2022
@dbussink
Fix deprecated usage of set-output (#11844) (#11855) (#11866)
a4837aa 
* Fix deprecated usage of set-output (#11844) (#11855)

The `set-output` command is deprecated and will break in the future.
This moves to the new style for all our GitHub Actions.

See also https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Also upgrades some more runners to Ubuntu 20.04 that were missed in
previous backports.

Signed-off-by: Dirkjan Bussink <[email protected]>

* Upgrade to Ubuntu 20.04 for endtoend tests (#11113)

This extracts the update to Ubuntu 20.04 (and thus MySQL 8 by default)
just for the end to end tests and updates the associated tests.

Signed-off-by: Dirkjan Bussink <[email protected]>

Signed-off-by: Dirkjan Bussink <[email protected]>

Signed-off-by: Dirkjan Bussink <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshit-gangal harshit-gangal harshit-gangal approved these changes

@systay systay Awaiting requested review from systay systay is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

Assignees
No one assigned
Labels
Component: Build/CI Type: CI/Build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbussink @harshit-gangal