Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Move all ubuntu-18.04 to ubuntu-20.04 #11026

Closed
wants to merge 1 commit into from

Conversation

deepthi
Copy link
Member

@deepthi deepthi commented Aug 17, 2022

Description

Ideally we should run on ubuntu-latest but let's see if this works first.

Related Issue(s)

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@vitess-bot
Copy link
Contributor

vitess-bot bot commented Aug 17, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive. Additionally, flag names should use dashes (-) as word separators rather than underscores (_).
  • If a workflow is added or modified, each items in Jobs should be named in order to mark it as required. If the workflow should be required, the GitHub Admin should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

@dbussink
Copy link
Contributor

Ideally we should run on ubuntu-latest but let's see if this works first.

Probably good to define a specific version so we don't have to scramble if Actions changes ubuntu-latest. Fwiw, ubuntu-latest still points at 20.04 anyway and not at 22.04.

With 22.04 there's also other issues like it ships with OpenSSL 3.0 and only MySQL 8.0.30 has support for that. I guess binary packages might have those fixes backported by maintainers but it might be a friction point there. I also don't know if MySQL 5.7 would ever see OpenSSL 3.0 support so we might be stuck there with an older base for CI anyway.

@dbussink
Copy link
Contributor

Hmm, is the xtrabackup related issue that we've upgraded it also for MySQL 5.7 but we now get a version there that's doesn't work with 5.7? Since we already seemed to have MySQL 8.0 running against 20.04 if I read the diff right?

@dbussink
Copy link
Contributor

We also seem to have some other stuff that might now run against MySQL 8.0 and not 5.7?

--- FAIL: TestSchemaVersioning (0.25s)
[325](https://github.com/vitessio/vitess/runs/7952828721?check_suite_focus=true#step:11:326)
    vstreamer_test.go:169: insert into vitess_version values(1, 10) (0): event:
[326](https://github.com/vitessio/vitess/runs/7952828721?check_suite_focus=true#step:11:327)
        "type:FIELD field_event:{table_name:\"vitess_version\" fields:{name:\"id1\" type:INT32 table:\"vitess_version\" org_table:\"vitess_version\" database:\"vttest\" org_name:\"id1\" column_length:11 charset:63 column_type:\"int\"} fields:{name:\"id2\" type:INT32 table:\"vitess_version\" org_table:\"vitess_version\" database:\"vttest\" org_name:\"id2\" column_length:11 charset:63 column_type:\"int\"}}", want
[327](https://github.com/vitessio/vitess/runs/7952828721?check_suite_focus=true#step:11:328)
        "type:FIELD field_event:{table_name:\"vitess_version\" fields:{name:\"id1\" type:INT32 table:\"vitess_version\" org_table:\"vitess_version\" database:\"vttest\" org_name:\"id1\" column_length:11 charset:63 column_type:\"int(11)\"} fields:{name:\"id2\" type:INT32 table:\"vitess_version\" org_table:\"vitess_version\" database:\"vttest\" org_name:\"id2\" column_length:11 charset:63 column_type:\"int(11)\"}}"
[328](https://github.com/vitessio/vitess/runs/7952828721?check_suite_focus=true#step:11:329)
FAIL

That looks very much like an issue where on MySQL 5.7 integer lengths are still printed for a schema, but that doesn't happen anymore for MySQL 8.0.

dbussink added a commit to planetscale/vitess that referenced this pull request Aug 23, 2022
On MySQL 8.0 it's possible we get back a zero length state for session
state changed information. In this case, we treat this as no data being
present and continue.

This was exposed in vitessio#11026 but
I'm extracted this as a separate fix until that lands since this can
trigger spurious errors when it shouldn't.

Signed-off-by: Dirkjan Bussink <[email protected]>
vmg pushed a commit that referenced this pull request Aug 23, 2022
On MySQL 8.0 it's possible we get back a zero length state for session
state changed information. In this case, we treat this as no data being
present and continue.

This was exposed in #11026 but
I'm extracted this as a separate fix until that lands since this can
trigger spurious errors when it shouldn't.

Signed-off-by: Dirkjan Bussink <[email protected]>

Signed-off-by: Dirkjan Bussink <[email protected]>
dbussink added a commit to planetscale/vitess that referenced this pull request Aug 30, 2022
Extracted from vitessio#11026 to move CI
to 20.04 for the tabletmanager CI jobs.

Signed-off-by: Dirkjan Bussink <[email protected]>
@dbussink dbussink mentioned this pull request Aug 30, 2022
3 tasks
dbussink added a commit to planetscale/vitess that referenced this pull request Aug 30, 2022
Extracted from vitessio#11026

Signed-off-by: Dirkjan Bussink <[email protected]>
dbussink added a commit to planetscale/vitess that referenced this pull request Aug 30, 2022
This is extracted from vitessio#11026

Signed-off-by: Dirkjan Bussink <[email protected]>
frouioui pushed a commit that referenced this pull request Aug 30, 2022
Extracted from #11026 to move CI
to 20.04 for the tabletmanager CI jobs.

Signed-off-by: Dirkjan Bussink <[email protected]>

Signed-off-by: Dirkjan Bussink <[email protected]>
frouioui pushed a commit that referenced this pull request Aug 30, 2022
* Upgrade CI for unit tests to Ubuntu 20.04

Extracted from #11026

Signed-off-by: Dirkjan Bussink <[email protected]>

* Fix MySQL installation

Signed-off-by: Dirkjan Bussink <[email protected]>

Signed-off-by: Dirkjan Bussink <[email protected]>
frouioui pushed a commit that referenced this pull request Aug 30, 2022
This is extracted from #11026

Signed-off-by: Dirkjan Bussink <[email protected]>

Signed-off-by: Dirkjan Bussink <[email protected]>
dbussink added a commit to dbussink/vitess that referenced this pull request Aug 30, 2022
Extracted from vitessio#11026

Signed-off-by: Dirkjan Bussink <[email protected]>
@deepthi
Copy link
Member Author

deepthi commented Sep 8, 2022

Some parts of this have already been picked out and merged, and #11153 handles the rest. Hence, closing.

@deepthi deepthi closed this Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants