Save draft config #945
Save draft config #945
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ptbrowne
force-pushed
the
feat/multiple-hierarchy-roots
branch
from
3b845dc to
e0d2233
Compare
There was a problem hiding this comment.
Nice, a fantastic change 👏 💯
I wasn't able to fully test the feature, as it doesn't work on preview environment (which is expected I guess, as we don't connect to a DB there), but overall looks good!
Which option below matches copying a URL directly from the browser? Will this work or should the menu be used for sharing the chart?
| */ | ||
| export const updateConfig = async ( | ||
| key: string, | ||
| data: Exclude<Prisma.ConfigUpdateInput["data"], undefined>, |
When copying the URL manually, you get editing rights. I think your question shows the need to expand/improve the help text like so "The other person will be able to edit your chart. This is the same URL as when you copy manually from the adress bar.". @AnninaWalker Any thoughts on this or ways to make it shorter ?
I will connect the preview deployment to a DB. |
ptbrowne
force-pushed
the
save-draft-config
branch
from
1fab023 to
b3d58b0
Compare
ptbrowne
force-pushed
the
save-draft-config
branch
from
350744c to
7a3f665
Compare
ptbrowne
force-pushed
the
save-draft-config
branch
from
c3a939b to
3fe14c2
Compare
ptbrowne
force-pushed
the
feat/multiple-hierarchy-roots
branch
2 times, most recently
from
4b005f4 to
c315ea6
Compare
ptbrowne
force-pushed
the
save-draft-config
branch
from
3fe14c2 to
31a17a0
Compare
A new column "is_draft" is added to the config database
Chart is no longer saved in localStorage, it is persisted in the database When the chart is created, its draft status is set to true When publishing, the draft status is set to false
…ig to be editable
ptbrowne
force-pushed
the
save-draft-config
branch
from
31a17a0 to
eaa1171
Compare
|
this can be closed now, correct? |
|
Correct 👍 |
|
@ptbrowne As discussed in the meeting:
One more question:
Improvement in the UI Design: |
|
Thanks Kerstin, I will implement the improvements. Quick question, I notice that you capitalize every word, is it wanted/expected ? It looks to me like a germanism 😁 I do not think personally that we should capitalize all the words like that. If there is a rule for that, I am interested. |
|
@ptbrowne What you are referring to is called "Title Case". It's not germanism. In UX Writing, title case is known to be better understandable. It helps differentiate your title text from your body text. It's used for call to action elements like buttons and tabs. |
|
Wow, I did not know that and had never notice this in macOS 👍 Thanks for the explanation and the screenshot :) |
|
OK, just read a bit about that and it seems it differs from companies to companies across the web, and also depending on the country, the US being more prone to that. The rule seems to be "be consistent". Here is the article I read about this: https://uxloc.medium.com/when-to-use-sentence-case-and-title-case-161768eaab6e. Looking at admin.ch, they do not use that much Title case. Do they have a rule about that in the official guidelines ? |
If you are the author, of the chart you should see an Edit button in the warning banner, do you see it ? Did you expect to see it a the bottom of the chart ? 
|
|
(I am going to apply Title Case now, but I think it is good to make sure that it is a visualize.admin guideline) |
|
Is it possible to differentiate the view that a user sees when a draft url was shared with them and a preview when the chart creator clicks on preview? |
|
Yes it would be possible to differentiate the two views. I'll do that in a next PR. |
Instead of saving the chart locally while it has not been published, we save it to the database.
This lets us share the creation link before the chart is published.
While a chart is not published, it is in draft