Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to share creation URLs #938

Closed
ptbrowne opened this issue Jan 19, 2023 · 4 comments
Closed

Ability to share creation URLs #938

ptbrowne opened this issue Jan 19, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@ptbrowne
Copy link
Collaborator

ptbrowne commented Jan 19, 2023

While creating a chart, we cannot share the URLs to anyone as the state of the chart is saved locally. This is confusing as users think they can share the URLs, but in fact those URLs do not work. It makes sharing a bad state hard as we have to reproduce exactly what the person has done.

Describe the solution you'd like

While creating a chart, the state should be saved server side, as a draft.
Drafts could be edited
Drafts can be shared with any other person, and the person can see and edit the draft (this could change when we introduce login)

This could greatly benefit bug reporting as we would be able to just send a draft URL.
Drafts are part of the login epic, but this could also be worked on without the login epic.
It would also make it possible to share Vercel comments on chart creation pages as the URL will be correct

Estimation: 2 days

@ptbrowne ptbrowne added the enhancement New feature or request label Jan 19, 2023
@AnninaWalker
Copy link
Contributor

@ptbrowne I've created some Mockups regarding this topic here
I've also added some Questions on the same Notion Page regarding Autosaving vs. Manually Saving. Happy to hear your input.

@ptbrowne
Copy link
Collaborator Author

PR: #945

@sosiology
Copy link
Contributor

@ptbrowne this issue has been around for a while, may I close it or what do you think?

@ptbrowne
Copy link
Collaborator Author

Since now, draft urls can be shared, the problem is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants