Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/homepage fixes #1936

Merged
merged 7 commits into from
Dec 9, 2024
Merged

Fix/homepage fixes #1936

merged 7 commits into from
Dec 9, 2024

Conversation

noahonyejese
Copy link
Contributor

@noahonyejese noahonyejese commented Dec 6, 2024

This PR:

How to test

  1. Go to this link
  2. Scroll to the newsletter & bug report section
  3. Review the header and description of both sections in Italian
  4. See how the text is now adjusted ✅
  5. Click "Subscribe", See how the IXT email is now in bcc ✅ See how there is a Contact Information section in each language ✅
  6. Click "Report a Bug", See how the IXT email is now in bcc ✅ See how there is a Contact Information section in each language ✅

CC: @sosiology

@noahonyejese noahonyejese self-assigned this Dec 6, 2024
Copy link

vercel bot commented Dec 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 8:13am

@sosiology
Copy link
Contributor

@noahonyejese the changes look good to me. Friendly reminder to also apply the changes to the Feature Request button as described here: #1932 it appears that the contact information is still missing there. Thank you!

cc: @adintegra

@noahonyejese noahonyejese merged commit 92a84e5 into main Dec 9, 2024
6 of 10 checks passed
@noahonyejese noahonyejese deleted the fix/homepage-fixes branch December 9, 2024 13:11
@florelina
Copy link

Thank you @noahonyejese Based on the task #1932 There is a dashed line between additional context and the contact information. Is there a reason we left this out? Is there a need to add this line? cc: @adintegra

@noahonyejese
Copy link
Contributor Author

Ah thanks @florelina wasn't sure due to the text's bellow
didn't have it I will implement this asap. 👍🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants