Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/smaller improvements #1823

Merged
merged 8 commits into from
Nov 13, 2024
Merged

Fix/smaller improvements #1823

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ef9b8e1
fix: Moves Interactive ToggleSwitch below the X axis Title
noahonyejese Nov 7, 2024
350551a
refactor: Refactored Embed & Share into their own Comps.
noahonyejese Nov 7, 2024
b2b4e7e
chore: added langs. for Share & Embed for Profile
noahonyejese Nov 7, 2024
a8313b9
chore: Changed Translations for Data Sources
noahonyejese Nov 11, 2024
7898bb7
feat: Moved Datasets Section to the top of Configurator
noahonyejese Nov 11, 2024
0ae8d5b
feat: Implemented style & Translations
noahonyejese Nov 11, 2024
fa9d63f
fix: Fixed all typos and minor mistakes
noahonyejese Nov 12, 2024
81161f1
Merge branch 'main' into fix/smaller-improvements
noahonyejese Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions app/charts/shared/containers.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ export const useStyles = makeStyles<{}, {}, "chartContainer">(() => ({
},
}));

const INTERACTIVE_TOGGLE_SPACING = 20;
noahonyejese marked this conversation as resolved.
Show resolved Hide resolved

export const ChartContainer = ({ children }: { children: ReactNode }) => {
const [state] = useConfiguratorState(hasChartConfigs);
const isFreeCanvas = isLayoutingFreeCanvas(state);
Expand Down Expand Up @@ -71,6 +73,7 @@ export const ChartSvg = ({ children }: { children: ReactNode }) => {
{interactiveFiltersConfig?.calculation.active && (
<foreignObject
width={width - margins.right}
y={INTERACTIVE_TOGGLE_SPACING}
height="24"
style={{ display: "flex", textAlign: "right" }}
>
Expand Down
Loading
Loading