-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/smaller improvements #1823
Fix/smaller improvements #1823
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@noahonyejese thanks bug with the interactive filters LGTM! 👏 Will test:
|
Hi @sosiology the #1800 is implemented based on @KerstinFaye design Please feel free to compare. |
Proposals: @KerstinFaye should we remove the Beta flag or the notification (1) from the section I think especially the (1) is drawing enormous attention towards it causing it to be opened even tho this may not be something the user will want to use straight away? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks 💯
@noahonyejese for #1800 i noticed that the data sources are now shown at the top but the accordion is closed per default - so it still requires user interaction (opening the accordion) before the data set selected is visible, can we per default show the accordion open? |
@bprusinowski I will be wrapping this up a new PR |
@noahonyejese thanks Noah, yes. I think we could remove it now. @bprusinowski, @sosiology any opinion on this? |
@KerstinFaye I would wait until we finalize merging of cubes improvements. As we realistically won't have a new PROD release before they are completed, should be fine to wait a bit? We still need to wrap up #1849 and the grouped filters, drop-down options and table charts, right? Or we could keep it in other places (modal to add a dataset), just remove the label from |
Agree to keep the beta label until we have completed the improvements. Also, we are still waiting on feedback about the proposed placement at the top of the sidebar. |
This PR resolves #1818 , resolves #1800
Next Steps
How to Test (1800)
How to Test (1818)
How to Test (1758)