Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add temporal entity dimension filtering to dashboard filters #1568

Merged
merged 9 commits into from
Jun 6, 2024

Conversation

bprusinowski
Copy link
Collaborator

@bprusinowski bprusinowski commented Jun 6, 2024

...and fix the time range brush for TemporalEntityDimension in column charts.

Closes #1555

How to test

Time brush for temporal entity dimension based X axis

PR

  1. Go to this link.
  2. Open Horizontal Axis settings.
  3. Enable interactive filter.
  4. ✅ See that it's possible to filter the chart.

TEST

  1. Go to this link.
  2. Open Horizontal Axis settings.
  3. Enable interactive filter.
  4. ❌ See that it's not possible to filter the chart (NaN values displayed in the brush).

Temporal entity dimension in shared dashboard filters

PR

  1. Go to this link.
  2. Add another chart (e.g. line).
  3. Proceed to layout options.
  4. Switch to a dashboard layout.
  5. Enable shared Date filter.
  6. Filter the chart using the time brush.
  7. ✅ See that both charts are filtered as expected.

TEST

  1. Go to this link.
  2. Add another chart (e.g. line).
  3. Proceed to layout options.
  4. Switch to a dashboard layout.
  5. ❌ See that it's not possible to enable shared Date filter.

@bprusinowski bprusinowski requested a review from ptbrowne as a code owner June 6, 2024 12:14
Copy link

vercel bot commented Jun 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2024 3:51pm

Copy link
Collaborator

@ptbrowne ptbrowne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 👏 👏

@ptbrowne
Copy link
Collaborator

ptbrowne commented Jun 6, 2024

I think we could remove the Slider ticks when there are more than 50 ?

image

@bprusinowski bprusinowski merged commit 4363e67 into main Jun 6, 2024
3 of 4 checks passed
@bprusinowski bprusinowski deleted the fix/temporal-entity-filtering branch June 6, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✅ Check if temporal entity dimension work with dashboard shared filter
2 participants