Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✅ Check if temporal entity dimension work with dashboard shared filter #1555

Closed
ptbrowne opened this issue Jun 4, 2024 · 3 comments · Fixed by #1568
Closed

✅ Check if temporal entity dimension work with dashboard shared filter #1555

ptbrowne opened this issue Jun 4, 2024 · 3 comments · Fixed by #1568
Assignees
@bprusinowski
Labels
enhancement New feature or request

Comments

@ptbrowne
Copy link
Collaborator

ptbrowne commented Jun 4, 2024 •
edited
Loading

Wondering if TemporalEntityDimension wouldn't also work "out of the box", as it looks like it has a timeUnit just like TemporalDimension?

Originally posted by @bprusinowski in #1545 (comment)
@ptbrowne ptbrowne added the enhancement New feature or request label Jun 4, 2024
@ptbrowne ptbrowne mentioned this issue Jun 4, 2024
Merged
5 tasks
@bprusinowski bprusinowski self-assigned this Jun 5, 2024
@bprusinowski bprusinowski mentioned this issue Jun 6, 2024
Merged
@sosiology
Copy link
Contributor

@bprusinowski i tried to test on TEST and with the PR links
Time brush for temporal entity dimension based X axis -> works as expected on both the PR and on TEST
Temporal entity dimension in shared dashboard filters

  • On the PR when I switch to the dashboard layout the shared filter option is not shown: Image
  • On TEST i can activate the shared filter, however for the date i am only shown 01.1970, and cannot filter the chart with the time brush
    Image

Tested with https://test.visualize.admin.ch/en/v/uVzl9tEGzs_E?dataSource=Int

@bprusinowski bprusinowski reopened this Sep 25, 2024
@bprusinowski
Copy link
Collaborator

@sosiology should be fixed on TEST in ~20 mins :) Let me know if it still doesn't work as expected 👍

@sosiology
Copy link
Contributor

@bprusinowski the slider works now! Thanks :) 🎉

@sosiology sosiology changed the title Check if temporal entity dimension work with dashboard shared filter ✅ Check if temporal entity dimension work with dashboard shared filter Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bprusinowski bprusinowski

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@ptbrowne @sosiology @bprusinowski