-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save draft #1340
Merged
Merged
Save draft #1340
Changes from 1 commit
Commits
Show all changes
59 commits
Select commit
Hold shift + click to select a range
d974f43
fix: Add optional access to navigator.vendor deprecated property
ptbrowne 0294863
docs: Add table of contents
ptbrowne af8a102
refactor: Extract keys early
ptbrowne 56929a9
refactor: Use query cache & invalidation to facilitate mutation
ptbrowne aea33b7
feat: Add useMutate helper
ptbrowne 38dbb98
refactor: Remove config through useMutate
ptbrowne 42d977a
feat: Add draft published state
ptbrowne f81c149
feat: Ability to turn config into draft/publish it from chart list
ptbrowne c995497
refactor: Extract saveState from component
ptbrowne 3844279
fix: Config for existing chart is correctly fetched
ptbrowne 23dae00
refactor: Rename for clarity
ptbrowne 1d5792c
feat: Use menu instead of tooltip
ptbrowne 64b6359
fix fetch data
ptbrowne 9663353
refactor: Rename method
ptbrowne 4303529
refactor: Decompose effect in both parts
ptbrowne 9d77f58
feat: Show warning if viewing chart still in draft
ptbrowne ba80167
feat: Add save draft button
ptbrowne 867311c
fix: Add required chartId prop
ptbrowne af92a08
feat: Add translations for chart features
ptbrowne 22ad15a
refactor: Add docs and explicit the version
ptbrowne e6f5479
fix: Inverted message
ptbrowne 98d73f7
feat: Add published state as non optional
ptbrowne dded7a7
fix: button in button
ptbrowne 79786d3
feat: Make create and update config simpler, they take a config and w…
ptbrowne f32fb11
Show SaveAsDraft button inside layout options
ptbrowne e51afff
feat: Hide save as draft button if not logged in
ptbrowne 5134a9c
refactor: Rename SaveDraft button
ptbrowne 5000dde
feat: Ability to dismiss snack
ptbrowne fd452c9
fix: Can save in draft a new chart
ptbrowne ec1baed
refactor: Reduce case
ptbrowne a9c297c
refactor: Remove unnnecessary type
ptbrowne 1aa90d2
fix: Remove target blank
ptbrowne fc0d75b
feat: Show arrow for menu
ptbrowne 6c2842e
fix: Remove config call does not check incoming data from userId, che…
ptbrowne 424bbf2
fix: Gap
ptbrowne 431703f
feat: Show edit button on chart page if it's a draft
ptbrowne 07aded3
refactor: Extract Confirmation Dialog from actions
ptbrowne ac7621a
feat: Refactor actions to be able to show the primary one as button
ptbrowne 31897ca
fix: Typo
ptbrowne 2097c22
refactor: Split component and make title of visualisation table dynamic
ptbrowne a0fd5e0
feat: Show drafts and published configs separately
ptbrowne 394ea79
feat: Show actions differently for drafts & published
ptbrowne 2981ece
feat: Show only small check, less things to translate
ptbrowne 8dfdbf2
feat: Make button a bit more lively
ptbrowne b54f3fd
feat: Add translations
ptbrowne 18a823f
fix: Menu item takes the whole width
ptbrowne 8f5e588
fix: Correct import
ptbrowne e11e4b9
fix: Missing published state
ptbrowne d1ebad4
fix: Unused
ptbrowne 6b5846c
refactor: Extract row actions and confirmation dialog from profile-ta…
ptbrowne e9710a7
feat: Add xsmall variant to button sizes
ptbrowne 4b541df
feat: Show delete in red
ptbrowne 822381f
fix: Make all tables look the same
ptbrowne dd8bca6
refactor: Extract rename dialog
ptbrowne ce7c21b
feat: Wrap th cells into table row and extract styling to table
ptbrowne 47a83d6
fix: Delete should correctly work
ptbrowne 75ad1c9
fix: Correctly call confirmation if required
ptbrowne 76b02cf
fix: Typo
ptbrowne 076b30b
fix: Width exceeded 100%
ptbrowne File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the idea here was to have a symmetrical layout, not sure if we need to have this change – if you think so, then you should also update
LMRPanelHeaderLayout
class to mimic this 😄 Btw, as it's not used anywhere, maybe we can just remove this layout option :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem here was that the publish options + save draft would be wider than the panel. I think we have to see later how to improve. Myabe we can check this together tomorrow.