Save draft #1340

ptbrowne · 2024-02-15T07:56:35Z

Create new chart and save as draft
List drafts as a separate list inside the profile
Ability to publish a draft from profile
Ability to turn a published chart into a draft from profile
Show the draft button inside the "configure" view
Show the draft button inside the "layout" view
When viewing a draft, show a warning
When viewing a draft, ability for the owner to go to edit page

Introduction of a QueryCache mechanism similar to react-query Instead of modifying in place the data that we receive from the server, we invalidate it & refetch it

vercel · 2024-02-15T07:56:41Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
visualization-tool	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 20, 2024 9:17am

bprusinowski

Couldn't test yet due to failed deployment but code looks 💯 👏 Just a few remarks / questions :)

README.md

app/utils/use-fetch-data.ts

app/utils/chart-config/api.ts

app/pages/v/[chartId].tsx

app/components/chart-selection-tabs.tsx

app/config-types.ts

app/utils/chart-config/api.ts

…ill take care of removing state from it

…bles

bprusinowski

LGTM 👌

app/utils/chart-config/api.ts

app/pages/v/[chartId].tsx

bprusinowski · 2024-02-20T08:50:17Z

app/configurator/components/layout.tsx

@@ -47,7 +47,7 @@ const useStyles = makeStyles<Theme>((theme) => ({
  LMRPanelHeaderLayout: {
    width: "100%",
    display: "grid",
-    gridTemplateColumns: `${DRAWER_WIDTH}px minmax(22rem, 1fr) ${DRAWER_WIDTH}px`,
+    gridTemplateColumns: `${DRAWER_WIDTH}px minmax(22rem, 1fr) auto`,


I think the idea here was to have a symmetrical layout, not sure if we need to have this change – if you think so, then you should also update LMRPanelHeaderLayout class to mimic this 😄 Btw, as it's not used anywhere, maybe we can just remove this layout option :)

The problem here was that the publish options + save draft would be wider than the panel. I think we have to see later how to improve. Myabe we can check this together tomorrow.

bprusinowski · 2024-02-20T08:51:21Z

app/configurator/configurator-state.spec.tsx

+      JSON.stringify({
+        state: "CONFIGURING_CHART",
+        published_state: "PUBLISHED",
+        ...fakeVizFixture,
+      })


Maybe it also would make sense to apply migration here, to forget about updating this when config schema changes?

Will do in another PR.

app/login/components/profile-tables.tsx

ptbrowne added 17 commits February 12, 2024 14:50

fix: Add optional access to navigator.vendor deprecated property

d974f43

docs: Add table of contents

0294863

refactor: Extract keys early

af8a102

refactor: Use query cache & invalidation to facilitate mutation

56929a9

Introduction of a QueryCache mechanism similar to react-query Instead of modifying in place the data that we receive from the server, we invalidate it & refetch it

feat: Add useMutate helper

aea33b7

refactor: Remove config through useMutate

38dbb98

feat: Add draft published state

42d977a

feat: Ability to turn config into draft/publish it from chart list

f81c149

refactor: Extract saveState from component

c995497

fix: Config for existing chart is correctly fetched

3844279

refactor: Rename for clarity

23dae00

feat: Use menu instead of tooltip

1d5792c

fix fetch data

64b6359

refactor: Rename method

9663353

refactor: Decompose effect in both parts

4303529

feat: Show warning if viewing chart still in draft

9d77f58

feat: Add save draft button

ba80167

ptbrowne requested a review from bprusinowski as a code owner February 15, 2024 07:56

vercel bot had a problem deploying to Preview February 15, 2024 07:58 Failure

fix: Add required chartId prop

867311c

vercel bot had a problem deploying to Preview February 15, 2024 08:51 Failure

bprusinowski reviewed Feb 15, 2024

View reviewed changes

ptbrowne added 7 commits February 15, 2024 14:52

feat: Add translations for chart features

af92a08

refactor: Add docs and explicit the version

22ad15a

fix: Inverted message

e6f5479

feat: Add published state as non optional

98d73f7

fix: button in button

dded7a7

feat: Make create and update config simpler, they take a config and w…

79786d3

…ill take care of removing state from it

Show SaveAsDraft button inside layout options

f32fb11

vercel bot had a problem deploying to Preview February 16, 2024 16:10 Failure

ptbrowne force-pushed the feat/save-draft-2 branch from 5719c8b to 26e35ec Compare February 16, 2024 16:10

ptbrowne added 8 commits February 16, 2024 17:11

refactor: Split component and make title of visualisation table dynamic

2097c22

feat: Show drafts and published configs separately

a0fd5e0

feat: Show actions differently for drafts & published

394ea79

feat: Show only small check, less things to translate

2981ece

feat: Make button a bit more lively

8dfdbf2

feat: Add translations

b54f3fd

fix: Menu item takes the whole width

18a823f

fix: Correct import

8f5e588

ptbrowne force-pushed the feat/save-draft-2 branch from 26e35ec to 227c0d5 Compare February 16, 2024 16:11

ptbrowne added 2 commits February 16, 2024 17:21

fix: Missing published state

e11e4b9

fix: Unused

d1ebad4

ptbrowne force-pushed the feat/save-draft-2 branch from 3cd66bd to d1ebad4 Compare February 16, 2024 16:21

vercel bot deployed to Preview February 16, 2024 16:30 View deployment

ptbrowne added 8 commits February 19, 2024 14:44

refactor: Extract row actions and confirmation dialog from profile-ta…

6b5846c

…bles

feat: Add xsmall variant to button sizes

e9710a7

feat: Show delete in red

4b541df

fix: Make all tables look the same

822381f

refactor: Extract rename dialog

dd8bca6

feat: Wrap th cells into table row and extract styling to table

ce7c21b

fix: Delete should correctly work

47a83d6

fix: Correctly call confirmation if required

75ad1c9

vercel bot deployed to Preview February 20, 2024 08:29 View deployment

bprusinowski approved these changes Feb 20, 2024

View reviewed changes

ptbrowne added 2 commits February 20, 2024 10:04

fix: Typo

76b02cf

fix: Width exceeded 100%

076b30b

vercel bot deployed to Preview February 20, 2024 09:17 View deployment

ptbrowne merged commit 831203a into main Feb 20, 2024
4 of 6 checks passed

ptbrowne deleted the feat/save-draft-2 branch February 20, 2024 09:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Save draft #1340

Save draft #1340

ptbrowne commented Feb 15, 2024 •

edited

Loading

vercel bot commented Feb 15, 2024 •

edited

Loading

bprusinowski left a comment

bprusinowski left a comment

bprusinowski Feb 20, 2024

ptbrowne Feb 20, 2024 •

edited

Loading

bprusinowski Feb 20, 2024

ptbrowne Feb 20, 2024

Save draft #1340

Save draft #1340

Conversation

ptbrowne commented Feb 15, 2024 • edited Loading

vercel bot commented Feb 15, 2024 • edited Loading

bprusinowski left a comment

Choose a reason for hiding this comment

bprusinowski left a comment

Choose a reason for hiding this comment

bprusinowski Feb 20, 2024

Choose a reason for hiding this comment

ptbrowne Feb 20, 2024 • edited Loading

Choose a reason for hiding this comment

bprusinowski Feb 20, 2024

Choose a reason for hiding this comment

ptbrowne Feb 20, 2024

Choose a reason for hiding this comment

ptbrowne commented Feb 15, 2024 •

edited

Loading

vercel bot commented Feb 15, 2024 •

edited

Loading

ptbrowne Feb 20, 2024 •

edited

Loading