fix: Locale overwriting #1175
Merged
fix: Locale overwriting #1175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bprusinowski
force-pushed
the
fix/locale-overwriting
branch
from
81b858b to
aad7d94
Compare
...there is no need to specify the locale in pathname. Using this led to overwiting the locale, as we used the old locale, while the router was setting a new one on route change.
bprusinowski
force-pushed
the
fix/locale-overwriting
branch
from
aad7d94 to
8f27098
Compare
...to avoid showing stale data and updating the localised content once the data fetches in the background. This is needed as we do not reload the page via changing pathname when redirecting to versioned cube.
bprusinowski
force-pushed
the
fix/locale-overwriting
branch
from
ccd95ff to
08699cd
Compare
|
Sorry for spam @ptbrowne, should be good now 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1174.
This PR fixes overwriting of locale when redirecting to a versioned cube by removing locale from
pathname. There is no need to pass the locale here, and using it led to making the router switch to old locale, while it previously had already updated the locale viarouteChangeCompleteevent.This behavior was only visible when previewing larger cubes, probably due to a fact that it took longer to update the content and a small lag was introduced that made the broken behavior visible.