fix: Overwriting of locale when redirecting to versioned cube

...there is no need to specify the locale in pathname. Using this led to overwiting the locale, as we used the old locale, while the router was setting a new one on route change.

CHANGELOG.md

@@ -11,6 +11,7 @@ You can also check the [release page](https://github.com/visualize-admin/visuali
 
 - Fixes
   - Table docs now work correctly again
+  - Changing the locale when previewing a larger cube no longer triggers multiple locale switches
 
 # [3.22.5] - 2023-09-12
 

app/components/use-redirect-to-versioned-cube.spec.tsx

@@ -87,7 +87,7 @@ describe("use redirect to versioned cube", () => {
       versionedCube: { iri: "https://versioned-cube" },
     });
     expect(router.replace).toHaveBeenCalledWith({
-      pathname: "/de/browse",
+      pathname: "/browse",
       query: {
         dataset: "https://versioned-cube",
       },
@@ -100,7 +100,7 @@ describe("use redirect to versioned cube", () => {
       versionedCube: { iri: "https://versioned-cube2" },
     });
     expect(router.replace).toHaveBeenCalledWith({
-      pathname: "/de/browse",
+      pathname: "/browse",
       query: {
         dataset: "https://versioned-cube2",
       },

app/components/use-redirect-to-versioned-cube.tsx

@@ -48,7 +48,7 @@ export const useRedirectToVersionedCube = ({
 
       if (resp) {
         router.replace({
-          pathname: `/${locale}/browse`,
+          pathname: `/browse`,
           query: {
             ...router.query,
             ...(router.query.iri ? { iri: resp.iri } : { dataset: resp.iri }),

app/pages/_app.tsx

@@ -26,11 +26,10 @@ export default function App({
   pageProps: { session, ...pageProps },
 }: AppProps) {
   const { events: routerEvents, asPath, locale: routerLocale } = useRouter();
+  const locale = parseLocaleString(routerLocale ?? "");
 
   useNProgress();
 
-  const locale = parseLocaleString(routerLocale ?? "");
-
   // Immediately activate locale to avoid re-render
   if (i18n.locale !== locale) {
     i18n.activate(locale);