Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Interactive filters issues #1066

Merged
merged 4 commits into from
Jun 14, 2023
Merged

Conversation

bprusinowski
Copy link
Collaborator

@bprusinowski bprusinowski commented Jun 13, 2023

Fixes #1065.

  • Interactive data filter is not being carried over to a new chart when switching chart types when it's used as a field in new chart,
  • A correct data is used to compute xEntireDomain for line chart,
  • Interactive timeRange filter is now again correctly carried over when switching chart type

How to test

  1. Go to https://visualization-tool-git-fix-interactive-filters-issues-ixt1.vercel.app/en/create/new?cube=https://environment.ld.admin.ch/foen/ubd000502_sad_01/13
  2. Change horizontal axis to Greenhouse gas.
  3. Make Year data filter interactive.
  4. Switch chart type to line.
  5. See that no interactive filter is applied.
  6. Add Year interactive filter.
  7. See that it works correctly.

@bprusinowski bprusinowski requested a review from ptbrowne as a code owner June 13, 2023 11:59
@vercel
Copy link

vercel bot commented Jun 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2023 0:20am

@bprusinowski
Copy link
Collaborator Author

hey @ptbrowne 👋 I am going to merge, but I'll tackle any feedback in following PRs 👍

@bprusinowski bprusinowski merged commit 3e5d8db into main Jun 14, 2023
@bprusinowski bprusinowski deleted the fix/interactive-filters-issues branch June 14, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lines chart : Interactive Filter does not work on temporal dimension "Year"
1 participant