fix: Deriving of timeRange interactive filter when changing chart type

visualize-admin · Jun 13, 2023 · 9429c32 · 9429c32
1 parent e56d012
commit 9429c32
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/app/charts/index.ts b/app/charts/index.ts
@@ -526,7 +526,7 @@ const interactiveFiltersAdjusters: InteractiveFiltersAdjusters = {
 
     return newChartConfig;
   },
-  time: {
+  timeRange: {
     active: ({ oldValue, newChartConfig }) => {
       return produce(newChartConfig, (draft) => {
         if (draft.interactiveFiltersConfig) {

diff --git a/app/configurator/config-types.ts b/app/configurator/config-types.ts
@@ -680,9 +680,18 @@ export type FieldAdjuster<
   measures: DataCubeMetadata["measures"];
 }) => NewChartConfigType;
 
-export type InteractiveFiltersAdjusters = {
+type AssureKeys<T, U extends { [K in keyof T]: unknown }> = {
+  [K in keyof T]: U[K];
+};
+
+export type InteractiveFiltersAdjusters = AssureKeys<
+  InteractiveFiltersConfig,
+  _InteractiveFiltersAdjusters
+>;
+
+type _InteractiveFiltersAdjusters = {
   legend: FieldAdjuster<ChartConfig, InteractiveFiltersLegend>;
-  time: {
+  timeRange: {
     active: FieldAdjuster<ChartConfig, boolean>;
     componentIri: FieldAdjuster<ChartConfig, string>;
     presets: {