-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Added poetry and lock pyparsing to ^2.4.7. (#86)
Summary: I think it's a good idea to revisit the discussion from facebookarchive/python-nubia#20. The tools have matured and considering the current state of Nubia, this would at least fix the problems we are having. Using poetry is considerably simpler and [distutils is deprecated](https://www.python.org/dev/peps/pep-0632/). The following changes are also included: * All dependencies have been set to the latest version and pyparsing to `^2.4.7` as `3.x` is not supported right now. Resolves facebookarchive/python-nubia#85. Pull Request resolved: facebookarchive/python-nubia#86 Reviewed By: AhmedSoliman Differential Revision: D32879106 Pulled By: AndreasBackx fbshipit-source-id: e07de2b1eaba3a9e82a5d12493a7079297e42727
- Loading branch information
Showing
8 changed files
with
636 additions
and
124 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,23 +2,23 @@ name: Nubia Build | |
|
||
on: [push, pull_request] | ||
jobs: | ||
build: | ||
build: | ||
runs-on: ubuntu-latest | ||
strategy: | ||
matrix: | ||
python-version: [3.7, 3.8] | ||
|
||
runs-on: ubuntu-latest | ||
strategy: | ||
matrix: | ||
python-version: [3.7, 3.8] | ||
|
||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Set up Python ${{ matrix.python-version }} | ||
uses: actions/setup-python@v2 | ||
with: | ||
python-version: ${{ matrix.python-version }} | ||
- name: Install dependencies | ||
run: | | ||
python -m pip install --upgrade pip setuptools wheel | ||
if [ -f requirements-dev.txt ]; then pip install -r requirements-dev.txt; fi | ||
- name: Test with nosetests | ||
run: | | ||
nosetests --with-coverage --cover-package=nubia | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Set up Python ${{ matrix.python-version }} | ||
uses: actions/setup-python@v2 | ||
with: | ||
python-version: ${{ matrix.python-version }} | ||
- name: Install poetry | ||
uses: abatilo/[email protected] | ||
- name: Install dependencies | ||
run: | | ||
poetry install | ||
- name: Test with nosetests | ||
run: | | ||
poetry run nosetests --with-coverage --cover-package=nubia |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.