This repository has been archived by the owner on May 30, 2022. It is now read-only.
Added poetry and lock pyparsing to ^2.4.7. #86
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
After consideration. Might be best to not change the version here and bump it to 0.3.0 together with the async changes from #81. |
|
@AndreasBackx has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
vinspam
added a commit
to vinspam/python-nubia
that referenced
this pull request
Oct 30, 2024
Summary: I think it's a good idea to revisit the discussion from facebookarchive/python-nubia#20. The tools have matured and considering the current state of Nubia, this would at least fix the problems we are having. Using poetry is considerably simpler and [distutils is deprecated](https://www.python.org/dev/peps/pep-0632/). The following changes are also included: * All dependencies have been set to the latest version and pyparsing to `^2.4.7` as `3.x` is not supported right now. Resolves facebookarchive/python-nubia#85. Pull Request resolved: facebookarchive/python-nubia#86 Reviewed By: AhmedSoliman Differential Revision: D32879106 Pulled By: AndreasBackx fbshipit-source-id: e07de2b1eaba3a9e82a5d12493a7079297e42727
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's a good idea to revisit the discussion from #20. The tools have matured and considering the current state of Nubia, this would at least fix the problems we are having. Using poetry is considerably simpler and distutils is deprecated.
The following changes are also included:
^2.4.7as3.xis not supported right now.Resolves #85.