Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated tests #327

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Automated tests #327

wants to merge 5 commits into from

Conversation

aktsbot
Copy link

@aktsbot aktsbot commented Oct 12, 2019

  • Added mocha and chai as dev dependencies.
  • Wrote a couple of tests available in test/index.js
  • Updated REAME file with the test command

@aktsbot aktsbot mentioned this pull request Oct 12, 2019
Open
@vinitshahdeo vinitshahdeo self-requested a review October 12, 2019 17:58
@vinitshahdeo
Copy link
Owner

@aktsbot Thanks for the PR. You may look into a few good first issues which are up for grabs.

✅ Link to the repository

@vinitshahdeo vinitshahdeo added the hacktoberfest Send PR and earn a free t-shirt label Oct 12, 2019
nessieSnippets
nessieSnippets reviewed Oct 20, 2019
View reviewed changes
test/index.js
var iq = require('../index');
var getRandomQuote = iq.getRandomQuote;
var getQuote = iq.getQuote;

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:nitpick: Change var to const ?

nessieSnippets
nessieSnippets reviewed Oct 20, 2019
View reviewed changes
Copy link

@nessieSnippets nessieSnippets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it - this helped me try and add mocha & contribute to another issue. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nessieSnippets nessieSnippets nessieSnippets left review comments

@vinitshahdeo vinitshahdeo Awaiting requested review from vinitshahdeo

Assignees
No one assigned
Labels
hacktoberfest Send PR and earn a free t-shirt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aktsbot @vinitshahdeo @nessieSnippets