Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add automated tests over "mocha" for main middlewares in the code. #257

Open
yashvardhan-kukreja opened this issue Oct 8, 2019 · 6 comments
Open

Add automated tests over "mocha" for main middlewares in the code. #257

yashvardhan-kukreja opened this issue Oct 8, 2019 · 6 comments
Labels
good first issue Good for newcomers hacktoberfest Send PR and earn a free t-shirt help wanted Extra attention is needed up for grabs Solve the issue and raise your first PR

Comments

@yashvardhan-kukreja
Copy link

yashvardhan-kukreja commented Oct 8, 2019 •
edited
Loading

Tests for testing the following middlewares

  • getQuote()
  • getRandomQuote()
@yashvardhan-kukreja yashvardhan-kukreja changed the title Add "chai" test over "mocha" for checking the response of the random quote. Add "chai" tests over "mocha" for main middlewares in the code. Oct 8, 2019
@yashvardhan-kukreja yashvardhan-kukreja changed the title Add "chai" tests over "mocha" for main middlewares in the code. Add automated tests over "mocha" for main middlewares in the code. Oct 8, 2019
@vinitshahdeo vinitshahdeo added good first issue Good for newcomers hacktoberfest Send PR and earn a free t-shirt help wanted Extra attention is needed labels Oct 9, 2019
@aktsbot
Copy link

aktsbot commented Oct 12, 2019

Hi there 👋
I'd like to add this in.

@aktsbot
Copy link

aktsbot commented Oct 12, 2019

#255 adds a .gitignore to the project. Can we get that merged first? Adding mocha as a dev dependency will include the node_modules folder into the commit.

@aktsbot
Copy link

aktsbot commented Oct 12, 2019

PR #327 adds automated tests.
Please review.

@vinitshahdeo
Copy link
Owner

@aktsbot Thanks for the PR. You may look into a few good first issues which are up for grabs.

✅ Link to the repository

@vinitshahdeo vinitshahdeo added the up for grabs Solve the issue and raise your first PR label Oct 12, 2019
@yashvardhan-kukreja
Copy link
Author

Even I added the PR @aktsbot but great work with your PR too :D

@yashvardhan-kukreja
Copy link
Author

@vinitshahdeo do check out my PR (PR #258)

@nessieSnippets nessieSnippets mentioned this issue Oct 20, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers hacktoberfest Send PR and earn a free t-shirt help wanted Extra attention is needed up for grabs Solve the issue and raise your first PR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vinitshahdeo @aktsbot @yashvardhan-kukreja