fix(player): cache_.currentTime is not updated when the current time is set #8285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is set Updating cache_.currentTime as soon as the currentTime is set avoids having to wait for the timeupdate event, which results in: - making cache_.currentTime more reliable - updating the progress bar on mouse up after dragging when the media is paused. See also: videojs#6232, videojs#6234, videojs#6370, videojs#6372
Codecov Report
@@ Coverage Diff @@
## main #8285 +/- ##
=======================================
Coverage 82.36% 82.36%
=======================================
Files 112 112
Lines 7483 7484 +1
Branches 1804 1805 +1
=======================================
+ Hits 6163 6164 +1
Misses 1320 1320
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mister-ben
approved these changes
May 22, 2023
gkatsev
approved these changes
May 22, 2023
edirub
pushed a commit
to edirub/video.js
that referenced
this pull request
Jun 8, 2023
…is set (videojs#8285) Updating cache_.currentTime as soon as the currentTime is set avoids having to wait for the timeupdate event, which results in: - making cache_.currentTime more reliable - updating the progress bar on mouse up after dragging when the media is paused. See also: videojs#6232, videojs#6234, videojs#6370, videojs#6372
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the delay in the update of
cache_.currentTime. Updatingcache_.currentTimeas soon as thecurrentTimeis set avoids having to wait for thetimeupdateevent, which results in:cache_.currentTimemore reliableprogress baron mouse up after dragging when the media is paused.See also: #6232, #6234, #6370, #6372, partially covers #8283
Specific Changes proposed
currentTimemethod to decrease the indentation levelcache_.currentTimewhencurrentTimeis used as a setter and thesecondsparameter has a value that can be converted to aNumberRequirements Checklist