Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug report] ProgressBar does not update as expected #6232

Closed
ustbhuangyi opened this issue Sep 16, 2019 · 2 comments
Closed

[Bug report] ProgressBar does not update as expected #6232

ustbhuangyi opened this issue Sep 16, 2019 · 2 comments

Comments

@ustbhuangyi
Copy link

Description

When pausing the video and click the ProgressBar, the video update but the ProgressBar does not update as expected.

Test it with 'https://codepen.io/gkatsev/pen/GwZegv?editors=1000#0'.

Steps to reproduce

  1. click Play Button
  2. click Pause Button
  3. click ProgressBar

Results

Expected

Video update and ProgressBar update to the right position.

Actual

Video update but ProgressBar does not update.

Additional Information

versions

videojs

after v7.5.1, v7.5.0 is fine.

browsers

Chrome、Firefox etc.

OSes

Mac OS

@welcome
Copy link

welcome bot commented Sep 16, 2019

👋 Thanks for opening your first issue here! 👋

If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.
To help make it easier for us to investigate your issue, please follow the contributing guidelines.

ustbhuangyi added a commit to ustbhuangyi/video.js that referenced this issue Sep 17, 2019
…ck the seek-bar.

First,when handle mosue down event of the seek-bar, we set player's scrubbing_ to true, and at the same tick, the update function called and we call super.update(). however, it returns undefined because the progress equals to the previous progress, the root cause is that we get cached currentTime. So we call super.update() in the next tick to make sure we can get the correct progress.Second, when toggle visibility of the document,we should not call this.enableInterval_() when the player is paused or waiting.
Fixed videojs#6232
@stale
Copy link

stale bot commented Nov 15, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the outdated Things closed automatically by stalebot label Nov 15, 2019
@stale stale bot closed this as completed Nov 22, 2019
@gkatsev gkatsev added confirmed and removed outdated Things closed automatically by stalebot labels Dec 23, 2019
@gkatsev gkatsev reopened this Dec 23, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.