Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fs): don't set player element css props on native fullscreen #6673

Merged
merged 1 commit into from
May 28, 2020
Merged

fix(fs): don't set player element css props on native fullscreen #6673

merged 1 commit into from
May 28, 2020

Conversation

gkatsev
Copy link
Member

@gkatsev gkatsev commented May 26, 2020

Fixes #6640

@gkatsev gkatsev mentioned this pull request May 26, 2020
Closed
@gkatsev
Copy link
Member Author

gkatsev commented May 26, 2020

Can be tested here https://deploy-preview-6673--videojs-docs.netlify.app/test-example/

@gkatsev gkatsev merged commit d6b07f0 into master May 28, 2020
@gkatsev gkatsev deleted the ios-native-fs branch May 28, 2020 14:29
gkatsev added a commit that referenced this pull request May 28, 2020
@gkatsev
fix(fs): don't set player element css props on native fullscreen
2b36c64 
Backport #6673 against 7.8.x release line.

Fixes #6640
@gkatsev gkatsev mentioned this pull request May 28, 2020
Merged
gkatsev added a commit that referenced this pull request May 28, 2020
@gkatsev
fix(fs): don't set player element css props on native fullscreen (#6677)
236b637 
Backport #6673 against 7.8.x release line.

Fixes #6640
@gkatsev gkatsev mentioned this pull request Jun 2, 2020
Closed
DispatchCommit added a commit to bitwave-tv/video.js that referenced this pull request Jun 9, 2020
@DispatchCommit @mister-ben
@soroushchehresa @gkatsev @OwenEdwards @heff
Merge v7.8.3 (#1)
b5af482 
* fix: addChild with index should allow for children that are elements (videojs#6644)

The fix in videojs#6297 doesn't work where the child to insert before is an element rather than a component, e.g. the video element.
Check if the child to insert before is an element, as well as checking if it has an el_

* docs(README): Update CDN version urls (videojs#6658)

* fix(fs): don't set player element css props on native fullscreen (videojs#6673)

Fixes videojs#6640

* Update description of video.js in the package.json file, and add 'hls' keyword (videojs#6603)

* Update descritpion of video.js in the package.json file, and add 'hls' keyword

* Update package.json

Co-authored-by: Steve Heffernan <[email protected]>

Co-authored-by: mister-ben <[email protected]>
Co-authored-by: Soroush Chehresa <[email protected]>
Co-authored-by: Gary Katsevman <[email protected]>
Co-authored-by: Owen Edwards <[email protected]>
Co-authored-by: Steve Heffernan <[email protected]>
@DispatchCommit DispatchCommit mentioned this pull request Jun 9, 2020
Closed
7 tasks
onebytegone pushed a commit to silvermine/video.js that referenced this pull request Jul 13, 2021
@gkatsev @onebytegone
fix(fs): don't set player element css props on native fullscreen (vid…
9044228 
…eojs#6673)

Fixes videojs#6640
@gkatsev gkatsev mentioned this pull request Jul 21, 2021
Closed
@vladislavSp
Copy link

vladislavSp commented Jul 29, 2021 •
edited
Loading

Hi!
On IOS 14.6 in mobile safari caption (subtitles) is not displaying (fullscreen mode)
Styles for .video-js.vjs-fullscreen:not(.vjs-ios-native-fs) available (videojs vesion 7.11.8)
Its problem IOS or videojs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misteroneill misteroneill misteroneill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Captions are not displaying when using ios fullscreen mode
3 participants
@gkatsev @vladislavSp @misteroneill