Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CDN version #6658

Merged
merged 2 commits into from
May 26, 2020
Merged

Update CDN version #6658

merged 2 commits into from
May 26, 2020

Conversation

soroushchehresa
Copy link
Contributor

Description

Please describe the change as necessary.
If it's a feature or enhancement please be as detailed as possible.
If it's a bug fix, please link the issue that it fixes or describe the bug in as much detail.

Specific Changes proposed

Please list the specific changes involved in this pull request.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@welcome
Copy link

welcome bot commented May 17, 2020

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@gkatsev gkatsev merged commit 756fbfc into videojs:master May 26, 2020
@welcome
Copy link

welcome bot commented May 26, 2020

Congrats on merging your first pull request! 🎉🎉🎉

DispatchCommit added a commit to bitwave-tv/video.js that referenced this pull request Jun 9, 2020
* fix: addChild with index should allow for children that are elements (videojs#6644)

The fix in videojs#6297 doesn't work where the child to insert before is an element rather than a component, e.g. the video element.
Check if the child to insert before is an element, as well as checking if it has an el_

* docs(README): Update CDN version urls (videojs#6658)

* fix(fs): don't set player element css props on native fullscreen (videojs#6673)

Fixes videojs#6640

* Update description of video.js in the package.json file, and add 'hls' keyword (videojs#6603)

* Update descritpion of video.js in the package.json file, and add 'hls' keyword

* Update package.json

Co-authored-by: Steve Heffernan <[email protected]>

Co-authored-by: mister-ben <[email protected]>
Co-authored-by: Soroush Chehresa <[email protected]>
Co-authored-by: Gary Katsevman <[email protected]>
Co-authored-by: Owen Edwards <[email protected]>
Co-authored-by: Steve Heffernan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants