Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: regression for getting a player via the tech's id #4969

Merged
merged 3 commits into from
Feb 22, 2018

Conversation

gkatsev
Copy link
Member

@gkatsev gkatsev commented Feb 21, 2018

As part of #4836, this piece of code was removed because it was thought it was not needed as everything else covers it. Turns out it's needed.

video.js/src/js/video.js

Lines 103 to 107 in f6eaa5e

// Element may have a player attr referring to an already created player instance.
// If so return that otherwise set up a new player below
if (tag.player || Player.players[tag.playerId]) {
return tag.player || Player.players[tag.playerId];
}

@gkatsev gkatsev requested a review from misteroneill February 21, 2018 23:20
Copy link
Member

@misteroneill misteroneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@gkatsev gkatsev merged commit 0ace2a5 into master Feb 22, 2018
@gkatsev gkatsev deleted the get-player-tech-id branch February 22, 2018 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants