feat: Add getPlayer method to Video.js.
#4836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misteroneill
added
needs: LGTM
ldayananda
approved these changes
Jan 5, 2018
gkatsev
added
confirmed
and removed
needs: LGTM
|
test: ☑️ |
gkatsev
added a commit
that referenced
this pull request
Feb 22, 2018
As part of #4836, this piece of code was removed because it was thought it was not needed as everything else covers it. Turns out it's needed. https://github.com/videojs/video.js/blob/f6eaa5e2ae417ffe27251133e1d1212cd9afa8e2/src/js/video.js#L103-L107
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are cases where you want to get a player by an ID or an element, but not necessarily call
videojs()to do it - because you don't want to create a player where one is absent.Requirements Checklist