Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let font import be relative if possible #3996

Closed
wants to merge 1 commit into from

Conversation

cryptiklemur
Copy link

Description

This would allow the font import to pull from the node_modules directory relatively, instead of absolutely, for projects that use a bundler, and bundle this on their own

Specific Changes proposed

Changed import to use ~

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@gkatsev
Copy link
Member

gkatsev commented Jan 30, 2017

Is the ~ a known sass thing?

@cryptiklemur
Copy link
Author

thats a good question actually. It might only be a webpack thing. Can we make this import configurable? like fontawesome does

@gkatsev
Copy link
Member

gkatsev commented Jan 31, 2017

Yup, looks like it's a webpack thing. Also, apparently, it's currently broken (see #3998).
I'm going to close this out for now.

As for making that configurable, that's probably fine as long as the default build works correctly :). Are you importing the sass directly over the pre-built files?

@gkatsev gkatsev closed this Jan 31, 2017
@gkatsev
Copy link
Member

gkatsev commented Jan 31, 2017

Might be better to move the discussion into a "make font @import configurable" issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants