-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken SASS dependency #3998
Comments
I wonder if it's a change in node-sass/libsass since what we had used to work. Looks like that is exactly the issue. In the latest release, they changed how it works: sass/node-sass#1876 Can you open a PR to update node-sass to the latest (as a minimum) and change the |
Actually, need to do work that depends on this, so, I'll go ahead and fix it. Thanks for reporting it to get me to investigate, @vit-koumar. |
node-sass updated to remove the cwd from import paths. Fix videojs#3998
node-sass updated to remove the cwd from import paths. Fix #3998
node-sass updated to remove the cwd from import paths. Fix videojs#3998
Description
When trying to build a video.js project it fails on task
sass:build
complaining about not found file import.Steps to reproduce
npm i
grunt dist
Results
Expected
Script finishes with successfully with
Done, without errors.
Actual
Script finishes with an error
Aborted due to warnings.
Error output
Additional Information
The broken import is the line 5 in
src/css/video-js.scss
which is@import "node_modules/videojs-font/scss/icons";
. When I change it to@import "../../node_modules/videojs-font/scss/icons";
it works fine. I must be missing something.versions
videojs
5.x and also 6.x
browsers
N/A
OSes
Tried on Linux Debian Stretch
plugins
N/A
The text was updated successfully, but these errors were encountered: