Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-deprecate the videojs.players property #3299

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 0 additions & 50 deletions src/js/utils/create-deprecation-proxy.js

This file was deleted.

16 changes: 4 additions & 12 deletions src/js/video.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import TextTrack from './tracks/text-track.js';
import AudioTrack from './tracks/audio-track.js';
import VideoTrack from './tracks/video-track.js';

import assign from 'object.assign';
import { createTimeRanges } from './utils/time-ranges.js';
import formatTime from './utils/format-time.js';
import log from './utils/log.js';
Expand All @@ -25,7 +24,6 @@ import * as browser from './utils/browser.js';
import * as Url from './utils/url.js';
import extendFn from './extend.js';
import merge from 'lodash-compat/object/merge';
import createDeprecationProxy from './utils/create-deprecation-proxy.js';
import xhr from 'xhr';

// Include the built-in techs
Expand Down Expand Up @@ -153,21 +151,15 @@ videojs.options = Player.prototype.options_;
* @mixes videojs
* @method getPlayers
*/
videojs.getPlayers = function() {
return Player.players;
};
videojs.getPlayers = () => Player.players;

/**
* For backward compatibility, expose players object.
* Expose players object.
*
* @deprecated
* @memberOf videojs
* @property {Object|Proxy} players
* @property {Object} players
*/
videojs.players = createDeprecationProxy(Player.players, {
get: 'Access to videojs.players is deprecated; use videojs.getPlayers instead',
set: 'Modification of videojs.players is deprecated'
});
videojs.players = Player.players;

/**
* Get a component class object by name
Expand Down
45 changes: 0 additions & 45 deletions test/unit/utils/create-deprecation-proxy.test.js

This file was deleted.