Un-deprecate the videojs.players property #3299
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed among core committers, we've decided deprecating this property had too many disadvantages and not enough advantages. Also, this removes the `createDeprecationProxy` function as it was only used in the one place anymore.
|
We get rid of a file, too? Nice! LGTM |
|
Two files if you count the test - it's a nice bonus! |
|
LGTM! |
misteroneill
added
the
minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed among core committers, we've decided deprecating this property had too many disadvantages and not enough advantages.
Also, this removes the
createDeprecationProxyfunction as it was only used in the one place anymore.Specific Changes proposed
videojs.playersdeprecation wrapper.createDeprecationProxyand tests for it.importfromsrc/js/video.js.Requirements Checklist