Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of the deprecated use of Button Component #3236

Conversation

OwenEdwards
Copy link
Member

Description

Improve handling of the deprecated use of Button Component with a non-button HTML element, for backward compatibility.

Specific Changes proposed

If an HTML element other than a <button> is used in the Button Component, add properties and attributes as ClickableComponent does.

Requirements Checklist

  • Feature implemented / Bug fixed
  • Reviewed by Two Core Contributors

…-button HTML element, for backward compatibility.
@OwenEdwards
Copy link
Member Author

This addresses the issue raised in #3231, even though that will also be addressed in videojs-4to5.

@gkatsev
Copy link
Member

gkatsev commented Apr 4, 2016

LGTM.

@gkatsev gkatsev added confirmed minor This PR can be added to a minor release. It should not be added to a patch release. labels Apr 4, 2016
@gkatsev gkatsev closed this in 0f40f3f Apr 5, 2016
@gkatsev
Copy link
Member

gkatsev commented Apr 5, 2016

I'm just going to release this as part of 5.9.

@OwenEdwards OwenEdwards deleted the hotfix/improve-button-element-deprecation branch April 13, 2016 23:11
jgubman added a commit to jgubman/video.js that referenced this pull request Apr 26, 2016
* upstream/stable: (77 commits)
  v5.9.2
  @gkatsev grouped text track errors in the console, if we can. closes videojs#3259
  v5.9.1
  @gkatsev fixed text track tests for older IEs. closes videojs#3269
  revert 75116d4 adding chrome to travis (videojs#3254)
  @forbesjo added back the background color to the poster. closes videojs#3267
  @gkatsev fixed removeRemoteTextTracks not working with return value from addRemoteTextTracks. closes videojs#3253
  @gkatsev made the first emulated text track enabled by default. closes videojs#3248
  @mister-ben blacklisted Chrome for Android for playback rate support. closes videojs#3246
  @benjipott updated IS_CHROME to not be true on MS Edge. closes videojs#3232
  v5.9.0
  @andyearnshaw updated document event handlers to use el.ownerDocument. closes videojs#3230
  @chrisauclair added ARIA region and label to player element. closes videojs#3227
  @MCGallaspy added vttjs to the self-hosting guide. closes videojs#3229
  @forbesjo added chrome for PR tests. closes videojs#3235
  @OwenEdwards improved handling of deprecated use of Button component. closes videojs#3236
  v5.8.8
  @seescode fixed dragging on mute toggle changing the volume. Fixes videojs#3036. Closes videojs#3228
  @seescode fixed css failing on IE8 due to incorrect ie8 hack. Fixes videojs#3140. Closes videojs#3226.
  @vtytar fixed auto-setup failing if taking too long to load. Fixes videojs#2386. Closes videojs#3233.
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed minor This PR can be added to a minor release. It should not be added to a patch release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants