Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #3036 #3228

Closed
wants to merge 1 commit into from
Closed

Fixes issue #3036 #3228

wants to merge 1 commit into from

Conversation

seescode
Copy link
Contributor

This fixes #3036 where you toggle mute while dragging which makes the mute toggle stop working.

@gkatsev
Copy link
Member

gkatsev commented Mar 31, 2016

Thanks for the PR, though, while this "fixes" the issue, it also removes a very useful feature for the volume control. Without this feature, you have to precisely click and drag on the volume slider itself, an element 4 pixels high; this makes it a lot easier because it allows you to click and drag anywhere, it just allows you to drag in too many places.
Instead, the mousemove handler needs to be smarter and reject movement on the mute toggle button itself and only delegate to the volume bar when the move is elsewhere inside the main element.
Would you be up to making that change? Thanks.

@seescode
Copy link
Contributor Author

seescode commented Apr 1, 2016

Okay, I'll take a stab at it.

@gkatsev
Copy link
Member

gkatsev commented Apr 1, 2016

Awesome, thanks @seescode!

@OwenEdwards
Copy link
Member

Seems like you'd want to add the mouse event handlers to just the this.volumeBar component, not the whole VolumeMenuButton.

For V6, to fix keyboard & screen reader access, I'm looking at splitting the VolumeMenuButton into a grouping of controls rather than a specific single control, which will also fix this issue, but it'll change the DOM, so it'd be great if @seescode can fix this for V5.x.

@seescode
Copy link
Contributor Author

seescode commented Apr 2, 2016

Okay, I made the fix by attaching event handler to the vjs-menu-content. Please review.

@gkatsev
Copy link
Member

gkatsev commented Apr 4, 2016

LGTM.

@gkatsev gkatsev added patch This PR can be added to a patch release. needs: LGTM Needs one or more additional approvals labels Apr 4, 2016
@nickygerritsen
Copy link
Contributor

Yup LGTM too

@gkatsev gkatsev closed this in 4e45d21 Apr 4, 2016
@gkatsev gkatsev added confirmed and removed needs: LGTM Needs one or more additional approvals labels Apr 11, 2016
jgubman added a commit to jgubman/video.js that referenced this pull request Apr 26, 2016
* upstream/stable: (77 commits)
  v5.9.2
  @gkatsev grouped text track errors in the console, if we can. closes videojs#3259
  v5.9.1
  @gkatsev fixed text track tests for older IEs. closes videojs#3269
  revert 75116d4 adding chrome to travis (videojs#3254)
  @forbesjo added back the background color to the poster. closes videojs#3267
  @gkatsev fixed removeRemoteTextTracks not working with return value from addRemoteTextTracks. closes videojs#3253
  @gkatsev made the first emulated text track enabled by default. closes videojs#3248
  @mister-ben blacklisted Chrome for Android for playback rate support. closes videojs#3246
  @benjipott updated IS_CHROME to not be true on MS Edge. closes videojs#3232
  v5.9.0
  @andyearnshaw updated document event handlers to use el.ownerDocument. closes videojs#3230
  @chrisauclair added ARIA region and label to player element. closes videojs#3227
  @MCGallaspy added vttjs to the self-hosting guide. closes videojs#3229
  @forbesjo added chrome for PR tests. closes videojs#3235
  @OwenEdwards improved handling of deprecated use of Button component. closes videojs#3236
  v5.8.8
  @seescode fixed dragging on mute toggle changing the volume. Fixes videojs#3036. Closes videojs#3228
  @seescode fixed css failing on IE8 due to incorrect ie8 hack. Fixes videojs#3140. Closes videojs#3226.
  @vtytar fixed auto-setup failing if taking too long to load. Fixes videojs#2386. Closes videojs#3233.
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed patch This PR can be added to a patch release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mute toggle stops working
4 participants