fix: addChild with index should allow for children that are elements #6644
Conversation
mister-ben
changed the title
|
Thanks @mister-ben. I think we'd probably want to release it as a patch against 7.7, 7.8 and master. Thoughts? |
There was a problem hiding this comment.
Thanks @mister-ben . I verified that this fixes a bug we've been having. For future reference, we were doing this from within a Component class:
player.addChild(this, {}, 0)
With the idea being we wanted to insert our component before the
|
@gkatsev makes sense, i've branches off those tags ready once this is approved. @evanfarina thanks for testing |
|
@mister-ben @gkatsev Any update as far as getting this in as a patch goes? |
|
@evanfarina sorry, got distracted with other things. Merging and releasing now. |
…6671) This is #6644 but against the 7.8.x release line. Co-authored-by: mister-ben <[email protected]>
…6672) This is #6644 but against the 7.7.x release line. Co-authored-by: mister-ben <[email protected]>
|
@evanfarina 7.7.7! is now out with this change. It's also in 7.8.2 if you felt like updating to that release line. It's also in master as of this change. Thanks for the changes @mister-ben! |
* fix: addChild with index should allow for children that are elements (videojs#6644) The fix in videojs#6297 doesn't work where the child to insert before is an element rather than a component, e.g. the video element. Check if the child to insert before is an element, as well as checking if it has an el_ * docs(README): Update CDN version urls (videojs#6658) * fix(fs): don't set player element css props on native fullscreen (videojs#6673) Fixes videojs#6640 * Update description of video.js in the package.json file, and add 'hls' keyword (videojs#6603) * Update descritpion of video.js in the package.json file, and add 'hls' keyword * Update package.json Co-authored-by: Steve Heffernan <[email protected]> Co-authored-by: mister-ben <[email protected]> Co-authored-by: Soroush Chehresa <[email protected]> Co-authored-by: Gary Katsevman <[email protected]> Co-authored-by: Owen Edwards <[email protected]> Co-authored-by: Steve Heffernan <[email protected]>
Description
The fix in #6297 doesn't work where the child to insert before is an element rather than a component, e.g. the video element.
Specific Changes proposed
Check if the child to insert before is an element, as well as checking if it has an
el_Requirements Checklist