Update description of video.js in the package.json file, and add 'hls' keyword #6603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We also support most of DASH. Maybe we should add HLS and DASH to tags but not specifically call out HLS in the description? |
heff
reviewed
May 19, 2020
OwenEdwards
changed the title
|
I'm OK just striking Flash from the record given that in a couple of months it won't be a thing. |
|
And even mentioning Flash just encourages "how do I play RTMP?" |
heff
approved these changes
Jun 5, 2020
OwenEdwards
added a commit
that referenced
this pull request
Jun 5, 2020
Following on from #6603, change the keywords to match the updated description in `package.json`.
DispatchCommit
added a commit
to bitwave-tv/video.js
that referenced
this pull request
Jun 9, 2020
* fix: addChild with index should allow for children that are elements (videojs#6644) The fix in videojs#6297 doesn't work where the child to insert before is an element rather than a component, e.g. the video element. Check if the child to insert before is an element, as well as checking if it has an el_ * docs(README): Update CDN version urls (videojs#6658) * fix(fs): don't set player element css props on native fullscreen (videojs#6673) Fixes videojs#6640 * Update description of video.js in the package.json file, and add 'hls' keyword (videojs#6603) * Update descritpion of video.js in the package.json file, and add 'hls' keyword * Update package.json Co-authored-by: Steve Heffernan <[email protected]> Co-authored-by: mister-ben <[email protected]> Co-authored-by: Soroush Chehresa <[email protected]> Co-authored-by: Gary Katsevman <[email protected]> Co-authored-by: Owen Edwards <[email protected]> Co-authored-by: Steve Heffernan <[email protected]>
7 tasks
gkatsev
pushed a commit
that referenced
this pull request
Jun 19, 2020
Following on from #6603, change the keywords to match the updated description in `package.json`.
edirub
pushed a commit
to edirub/video.js
that referenced
this pull request
Jun 8, 2023
…ojs#6692) Following on from videojs#6603, change the keywords to match the updated description in `package.json`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Just a suggestion; update the description of video.js to better reflect what it is now, rather than what it was. It seems like this change should have happened when v7 was first released, but maybe it makes sense to do it now?