Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not call load after mediachange for hls playlist loader #1447

Merged
merged 5 commits into from
Nov 27, 2023
Merged

fix: do not call load after mediachange for hls playlist loader #1447

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
234bf06
fix: do not call load after mediachange for hls playlist loader
Nov 20, 2023
a713008
Merge branch 'main' of github.com:videojs/http-streaming into fix-hls…
Nov 27, 2023
de6ff40
chore: bump mux.js 7.0.1 to 7.0.2
Nov 27, 2023
d0abcdf
Revert "chore: bump mux.js 7.0.1 to 7.0.2"
Nov 27, 2023
944c2c0
Merge branch 'main' of github.com:videojs/http-streaming into fix-hls…
Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/playlist-controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,7 +673,10 @@
this.requestOptions_.timeout = requestTimeout;
}

this.mainPlaylistLoader_.load();
if (this.sourceType_ === 'dash') {
// we don't want to re-request the same hls playlist right after it was changed
this.mainPlaylistLoader_.load();

Check warning on line 678 in src/playlist-controller.js

View check run for this annotation

Codecov / codecov/patch

src/playlist-controller.js#L678 

Added line #L678 was not covered by tests
}

// TODO: Create a new event on the PlaylistLoader that signals
// that the segments have changed in some way and use that to
Expand Down