fix: do not call load after mediachange for hls playlist loader #1447
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During ABR switch or fast quality switch, we call
switchMedia_
which will callthis.mainPlaylistLoader_.media
with a new media. We request a new playlist and trigger amediachange
event right after the request.In playlist controller we listen to the
mediachange
and callthis.mainPlaylistLoader_.load()
in the load method, we hit the following check
So for live, we trigger
mediaupdatetimeout
, which means that we need to refresh a live playlist, so we start loading the playlist a second time.So we load the same playlist immediately (right after it was loaded), so we hit
playlistunchanged
flow.Specific Changes proposed
This line was introduced mainly to fix dash-specific issues in this PR:
#1339
so the easiest solution is to call it for dash only.
Requirements Checklist