#1490 Add support for X-Forwarded-Port header. #1491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| url.schema = "https"; | ||
| if (m_port != 443) url.port = m_port; | ||
| // Set URL port segment. | ||
| Nullable!ushort port; |
There was a problem hiding this comment.
Could simply use ushort port = 0; here, because 0 isn't a valid port anyway.
|
Okay, thanks! Merging in. |
MartinNowak
reviewed
Jan 1, 2018
| if (m_port != 80) url.port = m_port; | ||
| // Set URL schema segment. | ||
| if (auto xfp = this.headers.get("X-Forwarded-Proto")) { | ||
| url.schema = xfp; |
There was a problem hiding this comment.
I'd argue this should set the port to the default port for that schema for cases where X-Forwarded-Port isn't set.
There was a problem hiding this comment.
Setting no port (defaut of 0) is considered to be implicitly equal to setting the default port. Are you thinking of something in particular that is broken?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Honours the
X-Forwarded-Portheader, when present.