registerWebInterface() redirect ignores X-Forwarded-Port header

[mintyfresh]

Minimal case to reproduce,

@path("/users")
class Users {
    void index() {
        render!"index.dt";
    }
}

shared static this() {
    URLRouter router = new URLRouter;

    // . . .

    router.registerWebInterface(new Users);
}

Requests made to /users are redirected to /users/, however, the redirect includes the port number the vibe app accepted the request on. This is problematic for environments where the internal port number (which vibed is bound to) does not match the external port number (which requests arrive on). For example if the app listens on port 5000, but incoming requests are actually accepted on port 80.

I've set up a Heroku app that demonstrates this behavior. Note that it is running on a free dyno, and may take a while to spin up.

Works correctly: http://testrig.herokuapp.com/users/
Problem redirect: http://testrig.herokuapp.com/users
(May redirect to something like: http://testrig.herokuapp.com:48669/users/)

In the case of Heroku, this is particularly problematic as there is no control over what the internal port number is. It is assigned (via environment variable) whenever the app is deployed, and is usually different every time.

[s-ludwig]

Currently the server expects the "X-Forwarded-Host" header to be set by the proxy server - if that is given, it will ignore the local port. This works for simple setups, but should definitely be made customizable in the future. Does Heroku set any similar headers, or can it be made to?

[mintyfresh]

It appears Heroku does not set the X-Forwarded-Host header, but instead all of these,
https://devcenter.heroku.com/articles/http-routing#heroku-headers

Other major HTTP servers appear to support these, but this is probably the cause of the issue.

EDIT: Looking at vibe/http/server.d, it appears to check for X-Forwarded-Host and disregard related headers if it's not present.

[mintyfresh]

Resolved by #1491