Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SwiftPM, Xcode11 and iOS 13 support support against develop branch #51

Merged
merged 7 commits into from
Aug 25, 2019

Conversation

yoiang
Copy link
Contributor

@yoiang yoiang commented Aug 14, 2019

No description provided.

@yoiang yoiang changed the title SwiftPM support against develop branch SwiftPM, Xcode11 and iOS 13 support support against develop branch Aug 14, 2019
@yoiang
Copy link
Contributor Author

yoiang commented Aug 14, 2019

vs #50 as per requested!

@vhesener
Copy link
Owner

I'm sure you've given it some thought, property wrappers may save a ton of this boiler plate but more importantly be potentially a lot safer! In the midst of updating the tests I noticed a mismatched case, totally easy to do accidentally with such repetitive, dense code. Also means the tests might need to be elaborated on and test actual one to one calling.

@yoiang
...continuing the last PR convo in this PR

I have not considered property wrappers, but it takes creative folks from the outside (such as yourself) to think of some of this stuff, so thank you for the idea. I have never been satisfied with essentially exhausting every delegate method, but that seemed to be the only way to not leave out anyone using an obscure delegate method. This is why the unit tests are mostly sanity checks to make sure the number of delegate methods hasn't change with OS updates. I actually used a custom code generation script (since discarded) to generate most of the library boiler plate.

Being that this is the first time considering it, I can't immediately think of a way to use property wrappers in this fashion. Most examples in the blogosphere use anecdotes related to value constraining, so I'm having trouble thinking of a way to signature constrain. If you can think of just one example of replacing the method calls with a property wrapper, even if just pseudocode, let me know and it may spark an epic refactor that greatly reduces the amount of code in this repo. That would be an amazing feat.

Having said all that, I feel like this library will shortly become irrelevant once SwiftUI has become mainstream. SwiftUI has mostly added declaration or closures to almost every new UIKit equivalent and I'm excited for that to occur actually.

@vhesener vhesener merged commit 27ac4c3 into vhesener:develop Aug 25, 2019
@vhesener
Copy link
Owner

vhesener commented Aug 25, 2019

Addresses #52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants