SwiftPM, Xcode11 and iOS 13 support #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: Create _config.yml Initial 0.1.2 release (vhesener#17)
Exit beta and enter into reality
* master: Carthage support Develop (vhesener#19)
* Created contribution guidelines * Added CocoaPods podspec to repo * Fixed some readme spacings * Created script for jazzy and updated some typos
* master: Version 0.3 Conflicts: Supporting/cocoapods/Closures.podspec.json
* Support Swift 4.2
Conflicts: Xcode/Closures.xcodeproj/project.pbxproj Xcode/Closures/Source/UIBarButtonItem.swift
|
Ok I appreciate this. I need a little time to review but I have it in my queue. |
|
My pleasure, thanks so much for sharing the library! |
|
Can you please resubmit this to the develop branch instead of master? |
|
Sure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lemme know how it looks! 🖖
I'm sure you've given it some thought, property wrappers may save a ton of this boiler plate but more importantly be potentially a lot safer! In the midst of updating the tests I noticed a mismatched case, totally easy to do accidentally with such repetitive, dense code. Also means the tests might need to be elaborated on and test actual one to one calling.