Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thomasht86/update colpali notebooks #979

Merged
merged 5 commits into from
Nov 22, 2024

Conversation

thomasht86
Copy link
Collaborator

@thomasht86 thomasht86 commented Nov 21, 2024

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Re: #977 and #975
Was able to reproduce issue when running on Cuda backend.
Updated other notebooks as well.

  • update link to colab
  • type->dtype
  • use torch.amp.autocast for dtype-casting

@thomasht86 thomasht86 requested a review from jobergum November 21, 2024 16:11
@thomasht86 thomasht86 marked this pull request as ready for review November 21, 2024 16:11
@thomasht86
Copy link
Collaborator Author

will fix doctest (broken link in another PR)

@thomasht86 thomasht86 changed the title Thomasht86/fix colpali notebook Thomasht86/update colpali notebooks Nov 22, 2024
Copy link

@jobergum jobergum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@thomasht86 thomasht86 merged commit 6bf4808 into master Nov 22, 2024
43 of 46 checks passed
@thomasht86 thomasht86 deleted the thomasht86/fix-colpali-notebook branch November 22, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants