merge host info #544
Closed
merge host info #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
critical27
reviewed
Jun 25, 2019
| @@ -94,8 +99,11 @@ void ActiveHostsMan::loadHostMap() { | |||
| HostInfo info; | |||
| info.lastHBTimeInSec_ = time::TimeUtils::nowInSeconds(); | |||
| if (iter->val() == MetaServiceUtils::hostValOnline()) { | |||
| LOG(INFO) << "load host " << host.ip << ":" << host.port; | |||
| updateHostInfo({host.ip, host.port}, info); | |||
| bool found = hostsMap_.find({host.ip, host.port}) != hostsMap_.end(); | |||
There was a problem hiding this comment.
Maybe you need to add a lock here?
src/meta/ActiveHostsMan.cpp
Outdated
| @@ -94,8 +99,11 @@ void ActiveHostsMan::loadHostMap() { | |||
| HostInfo info; | |||
| info.lastHBTimeInSec_ = time::TimeUtils::nowInSeconds(); | |||
| if (iter->val() == MetaServiceUtils::hostValOnline()) { | |||
There was a problem hiding this comment.
I think we need to set status of hosts "which is online in kvstore but not in memory" to offline? Because the info in memory is more updated. After leader really receive heartbeat, it will set info to online.
| @@ -0,0 +1,54 @@ | |||
|
|
|||
There was a problem hiding this comment.
Maybe just put the ut in ActiveHostsManTest?
ghost
requested review from
ghost
closed this
yixinglu
pushed a commit
that referenced
this pull request
Aug 9, 2021
* re-change options for rebuild index batch number * add sleep options * 3 us Co-authored-by: yaphet <[email protected]>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue 532:
#532
merge host infos from kvstore.