-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge host info from kvstore and memory #532
Comments
Very good. |
1 similar comment
Very good. |
Why do we persist the active host info in kvstore? If this is the cache of the meta information we discussed earlier, we need to store other information as well. Please shed more light, or we can talk about this offline |
@sherman-the-tank |
In #550, @andychow01 fix this by loading info from kvstore lazily, when kvstore is ready, we can merge info from kvstore and memory. The reason of merging is that the host status in kvstore may be outdated because of leadership change. |
For now, ActiveHostsMan will load host info from kvstore when it start-up, so it have to wait until kvstore is ready. We can load host info in background thread and merge result from kvstore and memory to update the online/offline status. In that way, we can get rid of sleep when initializing kvstore.
The text was updated successfully, but these errors were encountered: