revise error messages. #5102
Merged
revise error messages. #5102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xtcyclist
force-pushed
the
fix_some_bad_null
branch
from
fe67189 to
f26eb88
Compare
xtcyclist
requested review from
czpmango,
Shylock-Hg,
Aiee,
codesigner,
jievince,
nevermore3 and
yixinglu
yixinglu
reviewed
Dec 23, 2022
xtcyclist
force-pushed
the
fix_some_bad_null
branch
from
2f4f9be to
36d1cfb
Compare
codesigner
reviewed
Dec 23, 2022
xtcyclist
force-pushed
the
fix_some_bad_null
branch
from
36d1cfb to
0c72a0c
Compare
codesigner
reviewed
Dec 23, 2022
codesigner
previously approved these changes
Dec 23, 2022
jievince
previously approved these changes
Dec 23, 2022
xtcyclist
force-pushed
the
fix_some_bad_null
branch
from
1c4f7a3 to
3b4f779
Compare
Shinji-IkariG
dismissed stale reviews from jievince and codesigner
via
3b4f779
xtcyclist
force-pushed
the
fix_some_bad_null
branch
from
3b4f779 to
1d43056
Compare
xtcyclist
force-pushed
the
fix_some_bad_null
branch
from
7c3777f to
9ee3d06
Compare
xtcyclist
force-pushed
the
fix_some_bad_null
branch
from
9ee3d06 to
2a50f36
Compare
jievince
approved these changes
Dec 26, 2022
codesigner
approved these changes
Dec 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Close #5097
Description:
NullType::BAD_TYPE triggers error in filter. We've decided to keep similar issues as the status quo.
How do you solve it?
Improved the error message, telling users how to bypass this problem.
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: