revise error messages.

vesoft-inc · Dec 23, 2022 · 2f4f9be · 2f4f9be
1 parent f26eb88
commit 2f4f9be
Showing 1 changed file with 9 additions and 6 deletions.
diff --git a/src/graph/executor/query/FilterExecutor.cpp b/src/graph/executor/query/FilterExecutor.cpp
@@ -65,9 +65,10 @@ StatusOr<DataSet> FilterExecutor::handleJob(size_t begin, size_t end, Iterator *
   for (; iter->valid() && begin++ < end; iter->next()) {
     auto val = condition->eval(ctx(iter));
     if (val.isBadNull() || (!val.empty() && !val.isImplicitBool() && !val.isNull())) {
-      return Status::Error("Failed to evaluate condition: %s. %s",
+      return Status::Error("Failed to evaluate condition: %s. %s%s",
                            condition->toString().c_str(),
-                           "For boolean conditions, please write <condition> == <true/false>.");
+                           "For boolean conditions, please write in their full forms like",
+                           " <condition> == <true/false> or <condition> IS NULL.");
     }
     if (!(val.empty() || val.isNull() || (val.isImplicitBool() && !val.implicitBool()))) {
       // TODO: Maybe we can move.
@@ -98,9 +99,10 @@ Status FilterExecutor::handleSingleJobFilter() {
     while (iter->valid()) {
       auto val = condition->eval(ctx(iter));
       if (val.isBadNull() || (!val.empty() && !val.isImplicitBool() && !val.isNull())) {
-        return Status::Error("Failed to evaluate condition: %s. %s",
+        return Status::Error("Failed to evaluate condition: %s. %s%s",
                              condition->toString().c_str(),
-                             "For boolean conditions, please write <condition> == <true/false>.");
+                             "For boolean conditions, please write in their full forms like",
+                             " <condition> == <true/false> or <condition> IS NULL.");
       }
       if (val.empty() || val.isNull() || (val.isImplicitBool() && !val.implicitBool())) {
         if (UNLIKELY(filter->needStableFilter())) {
@@ -123,9 +125,10 @@ Status FilterExecutor::handleSingleJobFilter() {
     for (; iter->valid(); iter->next()) {
       auto val = condition->eval(ctx(iter));
       if (val.isBadNull() || (!val.empty() && !val.isImplicitBool() && !val.isNull())) {
-        return Status::Error("Failed to evaluate condition: %s. %s",
+        return Status::Error("Failed to evaluate condition: %s. %s%s",
                              condition->toString().c_str(),
-                             "For boolean conditions, please write <condition> == <true/false>.");
+                             "For boolean conditions, please write in their full forms like",
+                             " <condition> == <true/false> or <condition> IS NULL.");
       }
       if (val.isImplicitBool() && val.implicitBool()) {
         Row row;